Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: collision with argument --out for ./client validator add ... #321

Merged
merged 2 commits into from
Sep 19, 2024
Merged

fix: collision with argument --out for ./client validator add ... #321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10ed4ec
fix: collision with argument `--out` for `./client validator add ...`
rasmus-kirk Sep 3, 2024
3042da3
Updated changelog
rasmus-kirk Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,7 @@ tmp/
gtu-drop-account.json
hie.yaml
out/
# Nix stuff
flake.nix
flake.lock
shell.nix
4 changes: 4 additions & 0 deletions ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

- Change `--out` flag for `./client validator add` to
`--validator-credentials-out`, fixing an issue where this command had two
conflicting`--out` options.

## 7.0.0

- Support node version 7 and protocol version 7.
Expand Down
2 changes: 1 addition & 1 deletion src/Concordium/Client/Commands.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1739,7 +1739,7 @@ bakerAddCmd =
<*> blockCommission
<*> (option (eitherReader amountFractionFromStringInform) (long "delegation-finalization-commission" <> metavar "DECIMAL-FRACTION" <> help ("Fraction the validator takes in commission from delegators on finalization rewards. " ++ rangesHelpString "finalization reward commission")))
)
<*> optional (strOption (long "out" <> metavar "FILE" <> help "File to write the validator credentials to, in case of successful transaction. These can be used to start the node."))
<*> optional (strOption (long "validator-credentials-out" <> metavar "FILE" <> help "File to write the validator credentials to, in case of successful transaction. These can be used to start the node."))
soerenbf marked this conversation as resolved.
Show resolved Hide resolved
)
(progDesc "Deploy validator credentials to the chain.")
)
Expand Down
Loading