This repository has been archived by the owner on Aug 16, 2024. It is now read-only.
wallet-connectors: WalletConnect: Implement binary message signing #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bisgardo
commented
Jul 6, 2023
bisgardo
changed the title
If the message is "binary" it's encoded into hex and the schema provided in an additional field (encoded as base64). If the wallet doesn't read the schema, it's just going to present it non-decoded. Unrelated change: Fixed helper functions in sample dapps for extracting the message of an error - WalletConnect has a habit of throwing errors with empty message, meaning that the error is erroneously type cast to a string.
The fix is not really correct (it will only work as expected for WalletConnect - other string and Error values will not look right) - the proper fix is described in the TODOs added in wallet-connectors:WalletConnect.ts.
…atch connected account
To match other PR... And alphabetizes... Keepachangelog doesn't seem to suggest any ordering.
DOBEN
force-pushed
the
walletconnect/sign-message-schema
branch
from
609c3b8 to
002dfbf
Compare
DOBEN
force-pushed
the
walletconnect/sign-message-schema
branch
from
c5ad794 to
89f5e8c
Compare
DOBEN
force-pushed
the
walletconnect/sign-message-schema
branch
from
89f5e8c to
d82d787
Compare
DOBEN
force-pushed
the
walletconnect/sign-message-schema
branch
from
4823c0c to
d75ee44
Compare
Radiokot
approved these changes
Apr 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Support signing binary messages with schema over WalletConnect.
Changes
If the message is "binary" it's encoded into hex and the schema provided in an additional field (encoded as base64). If the wallet doesn't read the schema, it's going to present it non-decoded. And of course sign the hex encoding of the bytes rather than the bytes themselves.
Resolves CBW-1211.