Clean up based on PR review

Concordium · Oct 4, 2023 · 23840a1 · 23840a1
1 parent 57017ce
commit 23840a1
Show file tree

Hide file tree

Showing 10 changed files with 242 additions and 1,677 deletions.
diff --git a/.github/workflows/pipeline.yml b/.github/workflows/pipeline.yml
@@ -107,6 +107,7 @@ jobs:
               uses: ./.github/actions/upload-artifact
               with:
                   name: build-debug
+                  # sdk/src is needed here because of sdk/src/grpc-api
                   path: |
                       ./packages/rust-bindings/lib
                       ./packages/sdk/lib

diff --git a/examples/cis2/tokenMetadata.ts b/examples/cis2/tokenMetadata.ts
@@ -2,6 +2,7 @@ import { CIS2Contract, ContractAddress } from '@concordium/web-sdk';
 import { ConcordiumGRPCNodeClient } from '@concordium/web-sdk/nodejs';
 import { credentials } from '@grpc/grpc-js';
 import meow from 'meow';
+import fetch from 'node-fetch';
 
 const cli = meow(
     `

diff --git a/examples/package.json b/examples/package.json
@@ -6,16 +6,11 @@
         "@concordium/web-sdk": "workspace:^",
         "@grpc/grpc-js": "^1.3.4",
         "@noble/ed25519": "^1.7.1",
-        "@typescript-eslint/eslint-plugin": "^6.7.0",
-        "@typescript-eslint/parser": "^6.7.0",
         "buffer": "^6.0.3",
-        "eslint": "^7.29.0",
-        "eslint-config-prettier": "^8.3.0",
-        "eslint-plugin-import": "^2.23.4",
-        "eslint-plugin-prettier": "^3.4.0",
-        "lint-staged": "^12.0.2",
         "meow": "11.0",
-        "prettier": "^2.3.2",
+        "node-fetch": "^3.3.2"
+    },
+    "devDependencies": {
         "ts-node": "10.9",
         "typescript": "^5.2.2"
     },

diff --git a/package.json b/package.json
@@ -31,36 +31,19 @@
     },
     "type": "module",
     "devDependencies": {
-        "@babel/core": "^7.17.10",
-        "@babel/plugin-transform-modules-commonjs": "^7.12.1",
-        "@babel/plugin-transform-runtime": "^7.12.1",
-        "@babel/preset-env": "^7.12.1",
         "@typescript-eslint/eslint-plugin": "^6.7.0",
         "@typescript-eslint/parser": "^6.7.0",
-        "babel-jest": "^27.0.6",
-        "babel-loader": "^8.1.0",
         "eslint": "^7.29.0",
         "eslint-config-prettier": "^8.3.0",
         "eslint-import-resolver-exports": "^1.0.0-beta.5",
         "eslint-import-resolver-typescript": "^2.7.1",
         "eslint-plugin-import": "^2.26.0",
         "eslint-plugin-prettier": "^3.4.0",
-        "glob": "^10.3.4",
         "husky": "^4.2.5",
-        "jest": "^29.6.2",
         "lint-staged": "^12.0.2",
         "markdown-link-check": "^3.1.4",
         "markdownlint-cli": "^0.34.0",
-        "prettier": "^2.3.2",
-        "stream-browserify": "^3.0.0",
-        "ts-jest": "^29.1.1",
-        "ts-node": "^10.9.1",
-        "typedoc": "^0.23",
-        "typedoc-plugin-merge-modules": "^4.0.1",
-        "typedoc-plugin-missing-exports": "^0.23",
-        "typescript": "^5.2.2",
-        "webpack": "^5.88.2",
-        "webpack-cli": "^5.1.4"
+        "prettier": "^2.3.2"
     },
     "scripts": {
         "test": "FORCE_COLOR=true yarn workspaces foreach --no-private run test --passWithNoTests",

diff --git a/packages/ccd-js-gen/package.json b/packages/ccd-js-gen/package.json
@@ -38,13 +38,6 @@
     },
     "devDependencies": {
         "@types/node": "^20.5.0",
-        "@typescript-eslint/eslint-plugin": "^6.7.0",
-        "@typescript-eslint/parser": "^6.7.0",
-        "eslint": "^7.29.0",
-        "eslint-config-prettier": "^8.3.0",
-        "eslint-plugin-import": "^2.23.4",
-        "eslint-plugin-prettier": "^3.4.0",
-        "prettier": "^2.3.2",
         "typescript": "^5.2.2"
     },
     "prettier": {

diff --git a/packages/rust-bindings/package.json b/packages/rust-bindings/package.json
@@ -88,7 +88,8 @@
         "ts-loader": "^9.4.4",
         "typescript": "^5.2.2",
         "wasm-pack": "^0.12.1",
-        "webpack": "^5.88.2"
+        "webpack": "^5.88.2",
+        "webpack-cli": "^5.1.4"
     },
     "dependencies": {
         "buffer": "^6.0.3"

diff --git a/packages/sdk/package.json b/packages/sdk/package.json
@@ -45,18 +45,10 @@
         "@types/jest": "^26.0.23",
         "@types/json-bigint": "^1.0.1",
         "@types/uuid": "^8.3.4",
-        "@typescript-eslint/eslint-plugin": "^6.7.0",
-        "@typescript-eslint/parser": "^6.7.0",
-        "babel-jest": "^27.0.6",
-        "eslint": "^7.29.0",
-        "eslint-config-prettier": "^8.3.0",
-        "eslint-plugin-prettier": "^3.4.0",
+        "glob": "^10.3.10",
         "grpc-tools": "^1.11.2",
         "grpc_tools_node_protoc_ts": "5.3.0",
-        "husky": "^4.2.5",
         "jest": "^29.6.2",
-        "lint-staged": "^12.0.2",
-        "prettier": "^2.3.2",
         "rimraf": "^5.0.1",
         "ts-jest": "^29.1.1",
         "typescript": "^5.2.2",
@@ -86,7 +78,6 @@
         "big.js": "^6.2.0",
         "bs58check": "^3.0.1",
         "buffer": "^6.0.3",
-        "cross-fetch": "3.1.5",
         "hash.js": "^1.1.7",
         "iso-3166-1": "^2.1.1",
         "json-bigint": "^1.0.0",

diff --git a/packages/sdk/test/ci/testHelpers.ts b/packages/sdk/test/ci/testHelpers.ts
diff --git a/packages/sdk/test/client/testHelpers.ts b/packages/sdk/test/client/testHelpers.ts
@@ -12,8 +12,6 @@ import {
     MobileWalletExport,
 } from '../../src/nodejs/index.js';
 
-// This makes sure the necessary types are added to `globalThis`
-// import 'isomorphic-fetch';
 import { ConcordiumGRPCNodeClient } from '../../src/nodejs/grpc.js';
 
 const TESTNET_NODE = 'node.testnet.concordium.com';