Merge pull request #197 from Concordium/fix-deploy-module-cost

Fix deploy module cost
Concordium · May 25, 2023 · f413f64 · f413f64
2 parents 3cd61f2 + 37fc285
commit f413f64
Show file tree

Hide file tree

Showing 7 changed files with 25 additions and 8 deletions.
diff --git a/packages/common/CHANGELOG.md b/packages/common/CHANGELOG.md
@@ -1,5 +1,11 @@
 # Changelog
 
+## 7.0.1 2023-05-25
+
+### Fixed
+
+- Cost calculation for `deployModule` transaction.
+
 ## 7.0.0 2023-05-15 
 
 ### Breaking changes

diff --git a/packages/common/package.json b/packages/common/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@concordium/common-sdk",
-    "version": "7.0.0",
+    "version": "7.0.1",
     "license": "Apache-2.0",
     "engines": {
         "node": ">=14.16.0"

diff --git a/packages/common/src/accountTransactions.ts b/packages/common/src/accountTransactions.ts
@@ -102,7 +102,12 @@ export class DeployModuleHandler
     implements AccountTransactionHandler<DeployModulePayload>
 {
     getBaseEnergyCost(payload: DeployModulePayload): bigint {
-        const cost: number = Math.round(payload.source.length / 10);
+        let length = payload.source.length;
+        if (payload.version === undefined) {
+            // Remove the 8 bytes from the embedded version and length.
+            length -= 8;
+        }
+        const cost = Math.floor(length / 10);
         return BigInt(cost);
     }
 

diff --git a/packages/nodejs/package.json b/packages/nodejs/package.json
@@ -60,7 +60,7 @@
         "build-dev": "tsc"
     },
     "dependencies": {
-        "@concordium/common-sdk": "7.0.0",
+        "@concordium/common-sdk": "7.0.1",
         "@grpc/grpc-js": "^1.3.4",
         "@protobuf-ts/grpc-transport": "^2.8.2",
         "buffer": "^6.0.3",

diff --git a/packages/web/CHANGELOG.md b/packages/web/CHANGELOG.md
@@ -1,5 +1,11 @@
 # Changelog
 
+## 4.0.1 2023-05-25
+
+### Changed
+
+- Bumped @concordium/common-sdk to 7.0.1. (Fixes `deployModule` cost)
+
 ## 4.0.0 2023-05-15
 
 ### Breaking Changes

diff --git a/packages/web/package.json b/packages/web/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@concordium/web-sdk",
-    "version": "4.0.0",
+    "version": "4.0.1",
     "license": "Apache-2.0",
     "browser": "lib/concordium.min.js",
     "types": "lib/index.d.ts",
@@ -48,7 +48,7 @@
         "webpack-cli": "^4.9.2"
     },
     "dependencies": {
-        "@concordium/common-sdk": "7.0.0",
+        "@concordium/common-sdk": "7.0.1",
         "@concordium/rust-bindings": "0.12.0",
         "@grpc/grpc-js": "^1.3.4",
         "@protobuf-ts/grpcweb-transport": "^2.8.2",

diff --git a/yarn.lock b/yarn.lock
@@ -1312,7 +1312,7 @@ __metadata:
   languageName: node
   linkType: hard
 
-"@concordium/[email protected].0, @concordium/common-sdk@workspace:packages/common":
+"@concordium/[email protected].1, @concordium/common-sdk@workspace:packages/common":
   version: 0.0.0-use.local
   resolution: "@concordium/common-sdk@workspace:packages/common"
   dependencies:
@@ -1375,7 +1375,7 @@ __metadata:
   version: 0.0.0-use.local
   resolution: "@concordium/node-sdk@workspace:packages/nodejs"
   dependencies:
-    "@concordium/common-sdk": 7.0.0
+    "@concordium/common-sdk": 7.0.1
     "@grpc/grpc-js": ^1.3.4
     "@noble/ed25519": ^1.7.1
     "@protobuf-ts/grpc-transport": ^2.8.2
@@ -1414,7 +1414,7 @@ __metadata:
   version: 0.0.0-use.local
   resolution: "@concordium/web-sdk@workspace:packages/web"
   dependencies:
-    "@concordium/common-sdk": 7.0.0
+    "@concordium/common-sdk": 7.0.1
     "@concordium/rust-bindings": 0.12.0
     "@grpc/grpc-js": ^1.3.4
     "@protobuf-ts/grpcweb-transport": ^2.8.2