Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module client and smart contract module schema #262

Merged
merged 12 commits into from
Sep 18, 2023

Conversation

limemloh
Copy link
Collaborator

@limemloh limemloh commented Sep 6, 2023

Purpose

Closes #245
Closes #246

Changes

  • Add ModuleClient module and type for interaction with a smart contract module deployed on chain.
  • Add modules for wrapped types for: Energy, BlockHash, TransactionHash, InitName, ContractName, Parameter and AccountSequenceNumber.
  • Add methods getInstanceInfo and checkOnChain on the generic contract client Contract.
  • Function getEmbeddedModuleSchema for getting the module schema embedded into a smart contract module source.
  • Function parseRawModuleSchema for parsing the module schema bytes.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@limemloh limemloh force-pushed the parse-module-schema branch from f079446 to 5ae5323 Compare September 8, 2023 06:58
@limemloh limemloh changed the base branch from smart-contract-module-client to rm-module September 8, 2023 07:37
@limemloh limemloh changed the base branch from rm-module to release-v10 September 11, 2023 15:42
@limemloh limemloh force-pushed the parse-module-schema branch 3 times, most recently from 2c46cb3 to 41f8e10 Compare September 11, 2023 17:32
@limemloh limemloh changed the title Parsing of smart contract module schema Module client and smart contract module schema Sep 11, 2023
@limemloh limemloh marked this pull request as ready for review September 11, 2023 17:37
Copy link
Collaborator

@soerenbf soerenbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks really good! Some minor things to consider:

packages/common/src/AccountSequenceNumber.ts Outdated Show resolved Hide resolved
packages/common/src/AccountSequenceNumber.ts Outdated Show resolved Hide resolved
packages/common/src/BlockHash.ts Outdated Show resolved Hide resolved
packages/common/src/AccountSequenceNumber.ts Outdated Show resolved Hide resolved
packages/common/src/ContractName.ts Outdated Show resolved Hide resolved
packages/common/src/TransactionHash.ts Outdated Show resolved Hide resolved
packages/common/src/Parameter.ts Outdated Show resolved Hide resolved
packages/common/src/schemaTypes.ts Outdated Show resolved Hide resolved
packages/common/src/schemaTypes.ts Show resolved Hide resolved
@limemloh limemloh merged commit d37da48 into release/10 Sep 18, 2023
10 checks passed
@limemloh limemloh deleted the parse-module-schema branch August 7, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants