-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix parameter serialization and deserialization #263
Conversation
1112d12
to
c0a3331
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this included breaking changes, we should merge this into release/10
instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (if Søren's comments are addressed 🙃)
Co-authored-by: Søren Bruus Zeppelin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Purpose
See #110
Changes
Breaking changes
json-bigint
meaning that they return bigints instead of numbers for all numbers no matter sizedeserializeReceiveReturnValue
deserializeReceiveError
deserializeInitError
deserializeTypeValue
Added
serialization.ts
is now handled byjson-bigint
meaning that all functions now correctly handles bigint inputsChecklist
hard-to-understand areas.