Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parameter serialization and deserialization #263

Merged
merged 8 commits into from
Sep 14, 2023

Conversation

rasmus-kirk
Copy link
Collaborator

@rasmus-kirk rasmus-kirk commented Sep 7, 2023

Purpose

See #110

Changes

Breaking changes

  • The following functions now parse using json-bigint meaning that they return bigints instead of numbers for all numbers no matter size
    • deserializeReceiveReturnValue
    • deserializeReceiveError
    • deserializeInitError
    • deserializeTypeValue

Added

  • All JSON serialization in serialization.ts is now handled by json-bigint meaning that all functions now correctly handles bigint inputs

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@rasmus-kirk rasmus-kirk force-pushed the fix-param-serialization branch from 1112d12 to c0a3331 Compare September 7, 2023 11:45
@rasmus-kirk rasmus-kirk marked this pull request as ready for review September 12, 2023 07:24
Copy link
Collaborator

@soerenbf soerenbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this included breaking changes, we should merge this into release/10 instead.

packages/common/CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@shjortConcordium shjortConcordium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (if Søren's comments are addressed 🙃)

@rasmus-kirk rasmus-kirk changed the base branch from main to release/10 September 14, 2023 08:03
Copy link
Collaborator

@soerenbf soerenbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rasmus-kirk rasmus-kirk merged commit 9c32f64 into release/10 Sep 14, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants