Support tree-shaking and split code into entrypoints #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolutions strategies
soerenbf
force-pushed
the
separate-code-modules
branch
from
d389dce to
59ff981
Compare
Merged
5 tasks
soerenbf
force-pushed
the
separate-code-modules
branch
from
5f85ddb to
8a45a31
Compare
soerenbf
force-pushed
the
separate-code-modules
branch
2 times, most recently
from
cf274b1 to
1a29048
Compare
soerenbf
force-pushed
the
separate-code-modules
branch
from
1a29048 to
6e99dde
Compare
soerenbf
force-pushed
the
separate-code-modules
branch
from
c4a5bb9 to
1eede3c
Compare
soerenbf
force-pushed
the
separate-code-modules
branch
from
015f4c6 to
97edb35
Compare
Co-authored-by: Emil Holm Gjørup <[email protected]>
limemloh
reviewed
Sep 15, 2023
| @@ -4,7 +4,7 @@ import * as Gen from '@concordium/ccd-js-gen'; | |||
| import * as Path from 'node:path'; | |||
| import * as Url from 'node:url'; | |||
| import meow from 'meow'; | |||
There was a problem hiding this comment.
This example seems to fail building now
soerenbf
added a commit
to Concordium/concordium-dapp-libraries
that referenced
this pull request
Sep 20, 2023
In preparation of releasing Concordium/concordium-node-sdk-js#266, we need to also update the libraries included in this repo to be tree-shakable. ## Changes - Added exports field to package.json - Add ESM build target, and resolve to ES module by default ## Checklist - [x] My code follows the style of this project. - [x] The code compiles without warnings. - [x] I have performed a self-review of the changes. - [x] I have documented my code, in particular the intent of the hard-to-understand areas. - [x] (If necessary) I have updated the CHANGELOG.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Make it possible to include only the functionality you need from the SDK for your concordium web3 application.
Changes
Checklist
hard-to-understand areas.