Use schema information when generating client #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
limemloh
force-pushed
the
ccd-js-gen-schema-param
branch
from
1ea78cd to
d99f0c7
Compare
limemloh
changed the title
limemloh
force-pushed
the
ccd-js-gen-schema-param
branch
from
55a0dfa to
1e3d043
Compare
limemloh
force-pushed
the
ccd-js-gen-schema-param
branch
from
4cb8573 to
ac9f4ec
Compare
soerenbf
reviewed
Oct 4, 2023
limemloh
commented
Oct 6, 2023
limemloh
commented
Oct 6, 2023
abizjak
reviewed
Oct 8, 2023
There was a problem hiding this comment.
The readme in examples should be updated as well.
But also, there are as far as I see no tests of the generated code. That's not so problematic for the initial development since it's being tested on the fly, but it is a problem for maintenance.
I would expect some tests that would check at least a few example modules used as sources and then checking the correct functions are present in the generated module, that the generated TS modules actually type-check, and ideally also that the types are sensible, but this would probably require a bit more work.
As it is now it's too hard to make sure that the generated code is sensible unless I've missed something.
limemloh
force-pushed
the
ccd-js-gen-schema-param
branch
2 times, most recently
from
cc4f167 to
0c86233
Compare
limemloh
force-pushed
the
ccd-js-gen-schema-param
branch
from
0c86233 to
d340b75
Compare
abizjak
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Should be merged after #270.
Closes #254
Generate smart contract clients, which uses schema information to take structured parameters and provides function for parsing events, return values and error messages.
Example
An example of a wCCD client can be seen by running (from
./examples):The generated clients can be found in
examples/ccd-js-gen/wCCD/lib/Changes
ContractEventtype wrapper and update API to use it.