Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Platform agnostic sdk #278

Merged
merged 37 commits into from
Oct 4, 2023
Merged

Platform agnostic sdk #278

merged 37 commits into from
Oct 4, 2023

Conversation

soerenbf
Copy link
Collaborator

@soerenbf soerenbf commented Oct 2, 2023 •
edited
Loading

Purpose

Make SDK platform agnostic, i.e. able to run in both browser and nodeJS environments.

Closes #112

Changes

  • Remove web/nodejs specific SDK's
  • Move nodeJS code requiring nodeJS environment to subpath @concordium/web-sdk/nodejs

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@soerenbf
Remove JSON-RPC
5a9c634
@soerenbf
Remove grpc-v1 from nodejs sdk
8b09769
@soerenbf
Remove types associated only with v1 api
fbef3b0
@soerenbf
Explicitly state version of types versioned by node protocol version
25d3576
@soerenbf
update changelogs
16767b6
@soerenbf
Cleanup
db50900
@soerenbf
Lint fix
819a4aa
@soerenbf
Create grpc client from common with grpcweb transport
cf10c5c
@soerenbf
Create subclasses for transport layers
a2006e5
@soerenbf
Undo rename
10c51da
@soerenbf
Add wallet functionality to common
c1ddbf1
@soerenbf
Move nodejs specific client to subpath
6f2cb62
@soerenbf
Remove unused packages
3108f81
@soerenbf
Fix example sdk imports
04adb0f
@soerenbf
Ensure rust-bindings exposes target compatible with bundling for nodejs
548cc94
@soerenbf
Expose esm web target
702243d
@soerenbf
Configure browser map
2d562b6
@soerenbf
Merge branch 'api-strict-types' into remove-grpc-v1
f3ba044
@soerenbf
Fix failing tests
efc4047
@soerenbf
Merge branch 'remove-grpc-v1' into platform-agnostic-sdk
906964e
@soerenbf
Include tests depending on node connection (though not for CI)
077c25a
@soerenbf
Merge branch 'api-strict-types' into remove-grpc-v1
b9bd3b1
@soerenbf
Merge branch 'remove-grpc-v1' into platform-agnostic-sdk
0beaf38
@soerenbf soerenbf self-assigned this Oct 2, 2023
@soerenbf soerenbf force-pushed the platform-agnostic-sdk branch from 2458428 to f7194e2 Compare October 2, 2023 13:30
@soerenbf soerenbf force-pushed the platform-agnostic-sdk branch from f7194e2 to 8918814 Compare October 2, 2023 13:33
@soerenbf soerenbf requested a review from limemloh October 3, 2023 12:25
@soerenbf soerenbf marked this pull request as ready for review October 3, 2023 12:25
@soerenbf soerenbf changed the base branch from main to release/10 October 3, 2023 12:26
@soerenbf soerenbf force-pushed the platform-agnostic-sdk branch from 84599a7 to c4b4b77 Compare October 3, 2023 13:12
limemloh
limemloh approved these changes Oct 4, 2023
View reviewed changes
.github/workflows/pipeline.yml Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/typedoc.config.cjs Outdated Show resolved Hide resolved
docs/typedoc.config.cjs Outdated Show resolved Hide resolved
examples/types/index.d.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
packages/sdk/test/ci/testHelpers.ts Outdated Show resolved Hide resolved
@soerenbf soerenbf merged commit 065e221 into release/10 Oct 4, 2023
10 checks passed
@soerenbf soerenbf deleted the platform-agnostic-sdk branch October 4, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@limemloh limemloh limemloh approved these changes

Assignees

@soerenbf soerenbf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make easier to use with server-side-rendering frameworks
2 participants
@soerenbf @limemloh