Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types json serialize #279

Merged
merged 20 commits into from
Oct 11, 2023
Merged

Types json serialize #279

merged 20 commits into from
Oct 11, 2023

Conversation

soerenbf
Copy link
Collaborator

@soerenbf soerenbf commented Oct 5, 2023

Purpose

Adds functionality for formatting/parsing strong types introduced as JSON.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@soerenbf soerenbf force-pushed the types-json-serialize branch from 7b55600 to 72b0325 Compare October 5, 2023 13:25
@soerenbf soerenbf force-pushed the types-json-serialize branch from e3b881d to 853c576 Compare October 6, 2023 13:22
@soerenbf soerenbf requested a review from limemloh October 6, 2023 13:22
@soerenbf soerenbf marked this pull request as ready for review October 6, 2023 13:22
@soerenbf soerenbf self-assigned this Oct 6, 2023
@soerenbf soerenbf force-pushed the types-json-serialize branch from f6a1f79 to deb7dc9 Compare October 6, 2023 13:52
packages/sdk/src/types/util.ts Outdated Show resolved Hide resolved
packages/sdk/src/types/json.ts Outdated Show resolved Hide resolved
packages/sdk/src/types/json.ts Outdated Show resolved Hide resolved
packages/sdk/src/types/json.ts Show resolved Hide resolved
packages/sdk/src/types/json.ts Outdated Show resolved Hide resolved
packages/sdk/src/types/util.ts Outdated Show resolved Hide resolved
packages/sdk/src/types/AccountAddress.ts Outdated Show resolved Hide resolved
packages/sdk/src/types/util.ts Outdated Show resolved Hide resolved
packages/sdk/src/types/util.ts Show resolved Hide resolved
packages/sdk/src/types/util.ts Outdated Show resolved Hide resolved
@soerenbf soerenbf requested a review from limemloh October 10, 2023 13:24
Copy link
Collaborator

@limemloh limemloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

packages/sdk/src/types/json.ts Outdated Show resolved Hide resolved
packages/sdk/src/types/json.ts Outdated Show resolved Hide resolved
packages/sdk/src/types/json.ts Outdated Show resolved Hide resolved
@soerenbf soerenbf merged commit d4313f3 into release/10 Oct 11, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants