Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support "validator" terminology. #1081

Merged
merged 2 commits into from
Nov 17, 2023
Merged

Support "validator" terminology. #1081

merged 2 commits into from
Nov 17, 2023

Conversation

abizjak
Copy link
Contributor

@abizjak abizjak commented Nov 14, 2023 •
edited
Loading

Purpose

Closes #1080

Goes together with Concordium/concordium-client#286

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@abizjak abizjak mentioned this pull request Nov 14, 2023
Merged
5 tasks
limemloh
limemloh approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@limemloh limemloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe out of scope for this, but we also mention 'baked blocks' in the prometheus exporter

concordium-node/concordium-node/src/stats_export_service.rs

Line 371 in f940006

"Total number of blocks baked by the node since startup",

MilkywayPirate
MilkywayPirate approved these changes Nov 15, 2023
View reviewed changes
concordium-node/src/configuration.rs Outdated Show resolved Hide resolved
concordium-node/src/configuration.rs Outdated Show resolved Hide resolved
@abizjak abizjak merged commit 1b7d02b into main Nov 17, 2023
3 checks passed
@abizjak abizjak deleted the no-more-baker branch November 17, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@td202 td202 td202 left review comments

@MilkywayPirate MilkywayPirate MilkywayPirate approved these changes

@limemloh limemloh limemloh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support validator terminology in user options.
4 participants
@abizjak @td202 @limemloh @MilkywayPirate