-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync calls #227
Sync calls #227
Conversation
Fix some FFI bugs with mismatched parameters.
…ous setup. Revise some of the implementation details of the transfers to enable more use-cases.
concordium-consensus/src/Concordium/GlobalState/Persistent/BlockState/Modules.hs
Outdated
Show resolved
Hide resolved
concordium-consensus/src/Concordium/GlobalState/Persistent/BlockState/Modules.hs
Show resolved
Hide resolved
concordium-consensus/src/Concordium/GlobalState/Persistent/BlockState/Modules.hs
Outdated
Show resolved
Hide resolved
concordium-consensus/src/Concordium/GlobalState/Persistent/Instances.hs
Outdated
Show resolved
Hide resolved
1882f7e
to
3119bfc
Compare
Add tests for self-transfer.
concordium-consensus/src/Concordium/GlobalState/Basic/BlockState/Modules.hs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First leg.
concordium-consensus/src/Concordium/GlobalState/Basic/BlockState/Modules.hs
Outdated
Show resolved
Hide resolved
concordium-consensus/src/Concordium/GlobalState/Persistent/BlockState.hs
Outdated
Show resolved
Hide resolved
concordium-consensus/src/Concordium/GlobalState/Persistent/BlockState.hs
Outdated
Show resolved
Hide resolved
concordium-consensus/src/Concordium/GlobalState/Persistent/BlockState/Modules.hs
Show resolved
Hide resolved
concordium-consensus/src/Concordium/GlobalState/Persistent/BlockState/Modules.hs
Show resolved
Hide resolved
concordium-consensus/src/Concordium/GlobalState/Persistent/Instances.hs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
concordium-consensus/tests/scheduler/SchedulerTests/SmartContracts/V1/Transfer.hs
Outdated
Show resolved
Hide resolved
concordium-consensus/src/Concordium/GlobalState/Basic/BlockState/Instances.hs
Show resolved
Hide resolved
concordium-consensus/src/Concordium/GlobalState/Basic/BlockState/Instances.hs
Show resolved
Hide resolved
concordium-consensus/src/Concordium/Scheduler/WasmIntegration/V1.hs
Outdated
Show resolved
Hide resolved
concordium-consensus/src/Concordium/Scheduler/WasmIntegration/V1.hs
Outdated
Show resolved
Hide resolved
concordium-consensus/tests/scheduler/SchedulerTests/SmartContracts/V1/CrossMessaging.hs
Show resolved
Hide resolved
concordium-consensus/tests/scheduler/SchedulerTests/SmartContracts/V1/Transfer.hs
Outdated
Show resolved
Hide resolved
concordium-consensus/tests/scheduler/SchedulerTests/SmartContracts/V1/Transfer.hs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 😊
Purpose
Introduce V1 version of smart contracts that supports synchronous calls.
Implements part of #236
Changes
Depends on
Checklist
hard-to-understand areas.