Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for inactive validator events. #217

Merged
merged 6 commits into from
Dec 6, 2024
Merged

Support for inactive validator events. #217

merged 6 commits into from
Dec 6, 2024

Conversation

td202
Copy link
Contributor

@td202 td202 commented Dec 4, 2024 •
edited
Loading

Purpose

Closes: #215
Depends on: Concordium/concordium-base#581

Support inactive validator changes.

Changes

  • Update base. This includes updates that support the new suspended field on ConfigureBaker transactions.
  • Add SpecialTransactionOutcome cases for ValidatorSuspended and ValidatorPrimedForSuspension.
  • Add BakerEvent cases for BakerSuspended and BakerResumed.
  • Add ValidatorScoreParameters parameter update effect.
  • Rebuild generated protobuf code.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@td202 td202 requested review from drsk0 and soerenbf December 4, 2024 16:16
soerenbf
soerenbf approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@soerenbf soerenbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small thing that seems to be missing, otherwise LGTM! 🎉

src/v2/generated/concordium.v2.rs Show resolved Hide resolved
drsk0
drsk0 approved these changes Dec 5, 2024
View reviewed changes
Copy link

@drsk0 drsk0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@td202 td202 merged commit eb4a3ea into main Dec 6, 2024
4 checks passed
@td202 td202 deleted the inactive-validators branch December 6, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soerenbf soerenbf soerenbf approved these changes

@drsk0 drsk0 drsk0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rust SDK support for Inactive Validators (P8)
3 participants
@td202 @drsk0 @soerenbf