Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid building frontend for each environment and configure using env #290

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Avoid building frontend for each environment and configure using env #290

merged 2 commits into from
Nov 5, 2024

Conversation

limemloh
Copy link
Contributor

@limemloh limemloh commented Nov 4, 2024

Purpose

Make frontend docker image independent on the network, such that the same image can be used for mainnet, testnet, stagenet and so on.

Changes

  • Update Nuxt runtime configuration to take the relevant settings.
  • Allow network selector to be configured at runtime using env variables.
  • Provide .env files for different networks.
  • Update readme with instructions for how to run the image.

@limemloh limemloh requested a review from DOBEN November 4, 2024 21:49
DOBEN
DOBEN approved these changes Nov 5, 2024
View reviewed changes
frontend/README.md Outdated Show resolved Hide resolved
frontend/nuxt.config.ts Show resolved Hide resolved
@limemloh limemloh merged commit cbefa26 into main Nov 5, 2024
4 checks passed
@limemloh limemloh deleted the frontend-network-independent branch November 5, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DOBEN DOBEN DOBEN approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@limemloh @DOBEN