Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account delegation #325

Merged
merged 21 commits into from
Dec 17, 2024
Merged

Account delegation #325

merged 21 commits into from
Dec 17, 2024

Conversation

lassemand
Copy link
Contributor

@lassemand lassemand commented Dec 10, 2024 •
edited
Loading

Purpose

Implement account delegation

Changes

Added delegation to the api and indexer on rust ccd scan

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@lassemand lassemand changed the title Added delegation Account delegation Dec 10, 2024
@lassemand lassemand requested review from limemloh and DOBEN and removed request for limemloh December 16, 2024 08:57
limemloh
limemloh approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@limemloh limemloh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good only one minor thing, besides that I would like to avoid dealing with migrations for now, so we should keep to the one big SQL file, but we can discuss and potentially change that in another PR

backend-rust/migrations/0003_account_delegation.up.sql Outdated Show resolved Hide resolved
backend-rust/src/graphql_api.rs Show resolved Hide resolved
backend-rust/src/indexer.rs Outdated Show resolved Hide resolved
@lassemand lassemand requested a review from limemloh December 16, 2024 19:44
limemloh
limemloh approved these changes Dec 17, 2024
View reviewed changes
backend-rust/migrations/0001_initialize.up.sql Outdated Show resolved Hide resolved
DOBEN
DOBEN approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@DOBEN DOBEN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

backend-rust/src/indexer.rs Show resolved Hide resolved
backend-rust/src/indexer.rs Outdated Show resolved Hide resolved
limemloh
limemloh approved these changes Dec 17, 2024
View reviewed changes
backend-rust/migrations/0001_initialize.up.sql Outdated Show resolved Hide resolved
@lassemand lassemand merged commit e183bd9 into main Dec 17, 2024
3 checks passed
@lassemand lassemand deleted the lma/CCD-68/implement-accountdelegation branch December 17, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DOBEN DOBEN DOBEN approved these changes

@limemloh limemloh limemloh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lassemand @limemloh @DOBEN