Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement account rewards #335
base: main
Are you sure you want to change the base?
Implement account rewards #335
Changes from 33 commits
3c54e66
d9d856b
f053228
461ceef
929b43c
5576820
fd466fb
b3e9377
1432074
d6a789c
49b8809
b182e29
35af314
255214b
3e6352c
6e26f15
bdfc349
561e50e
0c8756b
24c1597
85728d4
555a756
2c2c7b0
bb931de
23528b8
62545fb
f333f7d
8c27505
8195974
007ed9a
11acf28
b54a153
1a07418
fc8f2ca
11cfd6f
252d0aa
e103cda
de0ff7b
d576baf
c90e5e3
97b58b2
5802f6e
c536493
cc08132
de7d628
6604fb0
16646a6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how this performs, since the query we need is the rewards for some
account_index
and this view is first filtering rewards across every account, and then we filter the ones related to the account (scanning potentially). Maybe postgres is smart enough to rearrange to avoid scanning, but a more direct approach would be to have the index:And then query directly:
Which I expect to scale better