Removing force asc ordering on the page #336
Conversation
| WHEN $4 THEN amount | ||
| WHEN $5 THEN num_txs | ||
| WHEN $6 THEN delegated_stake | ||
| END ASC", |
There was a problem hiding this comment.
Sorry for not mentioning this earlier when we spoke about it, but I just realized again why this is needed.
This ensures that the above/inner ordering does not leak, since the above/inner is related to whether user is querying first or last elements.
I think the solution is to use DESC instead of ASC on line 685, otherwise clicking next and then previous when paging the account list will change the ordering of the list in the frontend.
There was a problem hiding this comment.
It is a SELECT * FROM (...) ORDER BY CASE (..) ASC
That does nothing but change the order of the inner query. I do not follow how that can prevent a leak?
Could you for example write a test which demonstrates its purpose?
There was a problem hiding this comment.
We cannot desc it either because newest account is asc.
Purpose
The accounts page is expecting the page to be in the same ordering as the querying.
So basically saying this does not adhere GraphQL standards, but we are migrating the C# backend and hence we need to adjust to the expectations of the frontend not GraphQL.
Changes
Removing forced asc