Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't reconnect on request failures. #97

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Don't reconnect on request failures. #97

merged 2 commits into from
Oct 19, 2023

Conversation

abizjak
Copy link
Contributor

@abizjak abizjak commented Oct 19, 2023

Purpose

Respond with 503 in cases where the node responds with some form of resource exhaustion.

See Concordium/concordium-client#280

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

MilkywayPirate
MilkywayPirate approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@MilkywayPirate MilkywayPirate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

CHANGELOG needs to be updated.

@abizjak abizjak merged commit 13d691f into main Oct 19, 2023
2 checks passed
@abizjak abizjak deleted the better-errors branch October 19, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MilkywayPirate MilkywayPirate MilkywayPirate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abizjak @MilkywayPirate