Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed references to legacy wallets #1181

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

TinaKT
Copy link
Contributor

@TinaKT TinaKT commented Dec 11, 2024

Purpose

The purpose of the pull request is to remove info about legacy wallets in the pages under Docs/Concordium Protocol

Changes

Removed any mention of legacy wallets, including links, references, warnings, and notes notes.
Replaced with references and links to CryptoX where relevant.
Furthermore, removed redundant text i "Identities" page (no new text was added, just moved some to make content more clear).

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.

By submitting the contribution I accept the terms and conditions of the
Contributor License Agreement v1.0

@TinaKT TinaKT requested review from Radiokot and dragosgd December 11, 2024 11:02
Copy link
Contributor

@dragosgd dragosgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Radiokot Radiokot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, omit the identity attributes and their reveal, as agreed

@TinaKT TinaKT merged commit 0985d49 into main Dec 12, 2024
2 checks passed
@TinaKT TinaKT deleted the Remove-legacy-wallets-from-Concordium-Protocol-section branch December 12, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants