Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sc review build #1183

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Sc review build #1183

merged 2 commits into from
Dec 12, 2024

Conversation

dragosgd
Copy link
Contributor

Purpose

Finished review of the Build section in Smart Contracts according to the DOC-301 ticket

Changes

  • removed mention of dalloc and replaced with a reference to bump_alloc, which is the latest recommended custom allocator
  • added a note in the Use a custom allocator article mentioning to the user to be careful in the use of bump_alloc, with an example
  • added references to cargo-concordium rust crate documentation
  • replaced a reference to build-contract with a reference to setup-env, which is the main tutorial for installing dev tools
  • added a reference in JSON parameters to a related guide on how to use them

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

CLA acceptance

By submitting the contribution I accept the terms and conditions of the
Contributor License Agreement v1.0

@dragosgd dragosgd requested review from it09 and TinaKT December 12, 2024 11:54
@dragosgd dragosgd self-assigned this Dec 12, 2024
@dragosgd dragosgd merged commit 9777fce into main Dec 12, 2024
2 checks passed
@dragosgd dragosgd deleted the sc-review-build branch December 12, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants