Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finished review of deploy section #1188

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Finished review of deploy section #1188

merged 2 commits into from
Dec 13, 2024

Conversation

dragosgd
Copy link
Contributor

Purpose

Review and modify, if necessary, the deploy section of smart contracts.

Changes

  • changed one incorrect reference
  • added a reference to JSON Parameters

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

CLA acceptance

By submitting the contribution I accept the terms and conditions of the
Contributor License Agreement v1.0

@dragosgd dragosgd requested review from it09 and TinaKT December 13, 2024 09:04
@dragosgd dragosgd self-assigned this Dec 13, 2024
@dragosgd dragosgd merged commit fe8e621 into main Dec 13, 2024
2 checks passed
@dragosgd dragosgd deleted the sc-review-deploy branch December 13, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TinaKT TinaKT TinaKT approved these changes

@it09 it09 it09 approved these changes

Assignees

@dragosgd dragosgd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dragosgd @it09 @TinaKT