Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove comments on public_key_registry #849

Merged
merged 8 commits into from
Sep 13, 2023

Conversation

DOBEN
Copy link
Member

@DOBEN DOBEN commented Jul 25, 2023

Purpose

addresses #Concordium/concordium-rust-smart-contracts#258

Changes

  • Remove comments on public_key_registry and registration_tab.
  • Explain check_account_signature host function.
  • Add explanation on how to get the schema template with the commandcargo concordium build --schema-template-out -.

@DOBEN DOBEN force-pushed the remove-comments-about-public-key-registry branch from 4ea731b to 54ed2f5 Compare July 25, 2023 08:48
Copy link
Contributor

@dg-concordium dg-concordium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some changes to language directly in the front end/back end file. Otherwise LGTM.

Copy link
Contributor

@abizjak abizjak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Can we just deploy the new frontend and then merge & deploy this?

Co-authored-by: Aleš Bizjak <[email protected]>
@DOBEN
Copy link
Member Author

DOBEN commented Sep 13, 2023

The new front end 2.0.2 is deployed:
https://sponsored.testnet.concordium.com/

@DOBEN DOBEN merged commit 46adb9e into main Sep 13, 2023
2 checks passed
@DOBEN DOBEN deleted the remove-comments-about-public-key-registry branch September 13, 2023 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants