Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note for collector when using TLS #877

Merged
merged 10 commits into from
Oct 10, 2023
Merged

Note for collector when using TLS #877

merged 10 commits into from
Oct 10, 2023

Conversation

MilkywayPirate
Copy link
Contributor

@MilkywayPirate MilkywayPirate commented Sep 5, 2023

Purpose

Explain how to setup the collector if the node is configured with TLS.

Should not be published before node version 6.1.x. is released.

Changes

Added a note.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

Copy link
Contributor

@dg-concordium dg-concordium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only question is whether there will be updated config files for the Docker images. We have examples of those in the documentation too, so those may also need to be updated.

source/mainnet/net/guides/run-node-macos.rst Outdated Show resolved Hide resolved
@MilkywayPirate
Copy link
Contributor Author

MilkywayPirate commented Sep 6, 2023

Only question is whether there will be updated config files for the Docker images. We have examples of those in the documentation too, so those may also need to be updated.

There won't be any updated configuration files as far as I'm aware.
But thanks for pointing out the docker doc.

It should probably also be mentioned in the note box here https://developer.concordium.software/en/mainnet/net/guides/run-node.html talking about the collector.

@dg-concordium dg-concordium added documentation Improvements or additions to documentation Core Blockchain For core blockchain team labels Sep 14, 2023
source/mainnet/net/guides/run-node-macos.rst Outdated Show resolved Hide resolved
source/mainnet/net/guides/run-node-ubuntu.rst Outdated Show resolved Hide resolved
@dg-concordium
Copy link
Contributor

@dg-concordium dg-concordium marked this pull request as ready for review September 27, 2023 08:46
@dg-concordium dg-concordium merged commit e7ab2ef into main Oct 10, 2023
2 checks passed
@dg-concordium dg-concordium deleted the collector-tls branch October 10, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Blockchain For core blockchain team documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants