Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for W3S at scale and adding architecture (that page needs work and diagram). #254

Merged
merged 8 commits into from
Aug 19, 2024

Conversation

non-fungible-nelson
Copy link
Contributor

@non-fungible-nelson non-fungible-nelson commented Feb 22, 2024

Copy link

vercel bot commented Feb 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
doc-web3signer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 19, 2024 9:01pm

@CLAassistant
Copy link

CLAassistant commented Feb 22, 2024

CLA assistant check
All committers have signed the CLA.

Signed-off-by: Matt Nelson <[email protected]>

## The APIs

Web3Signer supports REST and [JSON-RPC APIs](../reference/api/_category_.json) to sign consensus layer and execution layer payloads respectively. These connections should be carefully secured. Web3Signer offers [TLS communication](../how-to/configure-tls.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"These connections should be carefully secured." Should we use the term "connections" for this? Could "requests", "ports", or something else work here?

@joaniefromtheblock joaniefromtheblock marked this pull request as draft July 5, 2024 13:35
@joaniefromtheblock
Copy link
Contributor

Hi @non-fungible-nelson. Made a couple of changes. Could you please review?

Copy link
Contributor

@joaniefromtheblock joaniefromtheblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a follow up PR for edited diagram

@joaniefromtheblock joaniefromtheblock merged commit 22c5674 into Consensys:main Aug 19, 2024
10 checks passed
docs/concepts/architecture.md Show resolved Hide resolved
docs/concepts/architecture.md Show resolved Hide resolved
docs/concepts/architecture.md Show resolved Hide resolved
docs/get-started/key-best-practices.md Show resolved Hide resolved
docs/get-started/key-best-practices.md Show resolved Hide resolved
docs/how-to/run-at-scale.md Show resolved Hide resolved
docs/how-to/run-at-scale.md Show resolved Hide resolved
docs/how-to/run-at-scale.md Show resolved Hide resolved
docs/how-to/store-keys/index.md Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's raise an issue to polish up this diagram in Figma (if it is accurate and up-to-date).

Copy link
Contributor

@joaniefromtheblock joaniefromtheblock Aug 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, noted that in the PR and just opened an issue. Will need to get further input from eng. The source image seems to be missing info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants