Bugfix for GAS_NEXT of CREATE's
#15
Open
+39
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- exceptional CREATE's consume all gas - aborted CREATE's consume only the upfront gas cost - CREATE's that raise the Failure Condition F consume the upfront gas cost + the 63/64ths given to the child context which they don't get back - CREATE's with empty init code get those 63/64ths back immediately so from the zkevm POV don't pay for it at all - CREATE's with nonempty init code consume the upfront ga cost + the 63/64th's which they provide to the child context (and may et back in part)
OlivierBBB
commented
Dec 2, 2024
| However, if the provided initialization code is \emph{empty}, then the execution context doesn't change and gets the entire ``\texttt{(63/64)-ths}'' back immediately. | ||
| The effective gas cost is therefore the \locCreateUpfrontGasCost{}. | ||
| If the provided initialization code is \emph{nonempty} then the execution context pays the \locCreateFullGasCost{}. | ||
| It \emph{may} get some of it back later down the line. |
There was a problem hiding this comment.
This is the fix. The issue was with Failure Condition F raising CREATE's not following the same pattern as other scenarios in \scenCreateNoContextChange
There was a problem hiding this comment.
For context, Failure Condition F in the yellow paper, around page 12. Here we only care about the state collision bit, i.e. the first line
There was a problem hiding this comment.
And the associated effect on returned gas
OlivierBBB
commented
Dec 2, 2024
| \left\{ \begin{array}{lcl} | ||
| \If \scenCreateException _{i} = 1 & \Then & \gasNext _{i} = 0 ~ (\trash) \\ | ||
| \If \scenCreateAbort _{i} = 1 & \Then & \gasNext _{i} = \gasActual _{i} - \locCreateUpfrontGasCost \\ | ||
| \If \scenCreateFCond _{i} = 1 & \Then & \gasNext _{i} = \gasActual _{i} - \locCreateFullGasCost \\ |
There was a problem hiding this comment.
This line right here is the bug fix: scenario/CREATE_FAILURE_CONDITION had wrong gas comuptation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CREATE's consume all gasCREATE's consume only the upfront gas costCREATE's that raise the Failure Condition F consume the upfront gas cost + the63/64thsgiven to the child context which they don't get backCREATE's with empty init code get those63/64thsback immediately so from the zkevm POV don't pay for it at allCREATE's with nonempty init code consume theupfront_gas_cost + 63/64thswhich they provide to the child context (and may et back in part)