Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor EthPublicKeyUtils to convert public key between Java, BC and Web3J libraries #1037

Merged
merged 11 commits into from
Nov 22, 2024
Merged

Refactor EthPublicKeyUtils to convert public key between Java, BC and Web3J libraries #1037

merged 11 commits into from
Nov 22, 2024

Conversation

usmansaleem
Copy link
Contributor

PR Description

Refactor EthPublicKeyUtils to convert public key between Java, BC and Web3J libraries

Fixed Issue(s)

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Testing

  • I thought about testing these changes in a realistic/non-local environment.

@usmansaleem usmansaleem self-assigned this Nov 21, 2024
@usmansaleem usmansaleem added the TeamCerberus Under active development by TeamCerberus @Consensys label Nov 21, 2024
@usmansaleem usmansaleem enabled auto-merge (squash) November 22, 2024 01:20
@usmansaleem usmansaleem merged commit 90dba64 into Consensys:master Nov 22, 2024
6 checks passed
@usmansaleem usmansaleem deleted the eth_public_key_utils_refactor branch November 22, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jframe jframe jframe approved these changes

Assignees

@usmansaleem usmansaleem

Labels
TeamCerberus Under active development by TeamCerberus @Consensys
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@usmansaleem @jframe