Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Commit Boost API - Request Signature #1045

Merged
merged 1 commit into from
Nov 28, 2024
Merged

feat: Commit Boost API - Request Signature #1045

merged 1 commit into from
Nov 28, 2024

Conversation

usmansaleem
Copy link
Contributor

PR Description

feat: Commit Boost API - Request Signature - https://commit-boost.github.io/commit-boost-client/api/
-- Routes and Handlers
-- Acceptance Test

Fixed Issue(s)

See #1017

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Testing

  • I thought about testing these changes in a realistic/non-local environment.

@usmansaleem
feat: Commit Boost API - Request Signature
a5c3d31 
 -- Routes and Handlers
 -- Acceptance Test
@usmansaleem usmansaleem self-assigned this Nov 27, 2024
@usmansaleem usmansaleem added the TeamCerberus Under active development by TeamCerberus @Consensys label Nov 27, 2024
@usmansaleem usmansaleem removed the TeamCerberus Under active development by TeamCerberus @Consensys label Nov 27, 2024
jframe
jframe approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@jframe jframe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@usmansaleem usmansaleem merged commit f8e60be into Consensys:master Nov 28, 2024
6 checks passed
@usmansaleem usmansaleem deleted the cb_sig_req branch November 28, 2024 05:16
@merklefruit merklefruit mentioned this pull request Nov 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jframe jframe jframe approved these changes

Assignees

@usmansaleem usmansaleem

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@usmansaleem @jframe