Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v11.0.0] testnet4 #2340

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from
Draft

[v11.0.0] testnet4 #2340

wants to merge 4 commits into from

Conversation

ouziel-slama
Copy link
Contributor

@ouziel-slama ouziel-slama commented Oct 13, 2024 •
edited
Loading

  • Add testnet4
  • Remove "testcoin"
  • Remove "customnet"
  • Dry hardcoded protocole changes
  • Double-check the spelling and grammar of all strings, code comments, etc.
  • Double-check that all code is deterministic that needs to be
  • Add tests to cover any new or revised logic
  • Ensure that the test suite passes
  • Update the project release notes
  • Update the project documentation, as appropriate, with a corresponding Pull Request in the Documentation repository

@ouziel-slama ouziel-slama marked this pull request as draft October 13, 2024 11:35
@ouziel-slama ouziel-slama changed the title Introduce testnet4 testnet4 Oct 13, 2024
@adamkrellenstein adamkrellenstein changed the title testnet4 [v11.0.0] testnet4 Oct 13, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 13, 2024
View reviewed changes
counterparty-core/counterpartycore/lib/ledger.py
@@ -713,7 +713,7 @@

def price(numerator, denominator):
"""Return price as Fraction or Decimal."""
if util.CURRENT_BLOCK_INDEX >= 294500 or config.TESTNET or config.REGTEST: # Protocol change.
if util.after_block_or_test_network(util.CURRENT_BLOCK_INDEX, 294500): # Protocol change.

Check warning

Code scanning / pylint

Unnecessary "else" after "return", remove the "else" and de-indent the code inside it. Warning

Unnecessary "else" after "return", remove the "else" and de-indent the code inside it.
counterparty-core/counterpartycore/lib/messages/order.py
and block_index <= 310500
and not config.TESTNET
or config.REGTEST
block_index >= 292000 and block_index <= 310500 and not util.is_test_network()

Check warning

Code scanning / pylint

Simplify chained comparison between the operands. Warning

Simplify chained comparison between the operands.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ouziel-slama @Ouziel