Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v11.0.0] Kill Addrindexrs #2343

Closed
wants to merge 5 commits into from
Closed

[v11.0.0] Kill Addrindexrs #2343

wants to merge 5 commits into from

Conversation

ouziel-slama
Copy link
Contributor

@ouziel-slama ouziel-slama commented Oct 14, 2024 •
edited
Loading

  • mock get_oldest_tx
  • use Elect for blockchain.scripthash.get_history and blockchain.scripthash.get_utxos
  • Double-check the spelling and grammar of all strings, code comments, etc.
  • Double-check that all code is deterministic that needs to be
  • Add tests to cover any new or revised logic
  • Ensure that the test suite passes
  • Update the project release notes
  • Update the project documentation, as appropriate, with a corresponding Pull Request in the Documentation repository

@ouziel-slama ouziel-slama changed the base branch from master to develop October 14, 2024 10:47
@ouziel-slama ouziel-slama marked this pull request as draft October 14, 2024 10:47
@adamkrellenstein adamkrellenstein changed the title Kill Addrindexrs v[11.0.0] Kill Addrindexrs Oct 14, 2024
@adamkrellenstein adamkrellenstein changed the title v[11.0.0] Kill Addrindexrs [v11.0.0] Kill Addrindexrs Oct 14, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 14, 2024
View reviewed changes
counterparty-core/counterpartycore/lib/api/api_v1.py
@@ -930,17 +924,13 @@

@dispatcher.add_method
def search_raw_transactions(address, unconfirmed=True, only_tx_hashes=False):
return backend.addrindexrs.search_raw_transactions(
return backend.electr.get_history(

Check warning

Code scanning / pylint

Unexpected keyword argument 'only_tx_hashes' in function call. Warning

Unexpected keyword argument 'only_tx_hashes' in function call.
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 14, 2024
View reviewed changes
counterparty-core/counterpartycore/lib/messages/dispenser.py
@@ -37,6 +38,17 @@
STATUS_CLOSED = 10
STATUS_CLOSING = 11

CURR_DIR = os.path.dirname(os.path.realpath(__file__))
with open(os.path.join(CURR_DIR, "data", "get_oldest_tx.json")) as f:

Check warning

Code scanning / pylint

Using open without explicitly specifying an encoding. Warning

Using open without explicitly specifying an encoding.
@ouziel-slama
Copy link
Contributor Author

replaced by #2864

@ouziel-slama ouziel-slama deleted the killaddrindexrs branch December 18, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ouziel-slama @Ouziel