Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ParentProcessChecker Thread #2808

Merged
merged 5 commits into from
Dec 9, 2024
Merged

Fix ParentProcessChecker Thread #2808

merged 5 commits into from
Dec 9, 2024

Conversation

ouziel-slama
Copy link
Contributor

@ouziel-slama ouziel-slama commented Dec 7, 2024 •
edited
Loading

  • Double-check the spelling and grammar of all strings, code comments, etc.
  • Double-check that all code is deterministic that needs to be
  • Add tests to cover any new or revised logic
  • Ensure that the test suite passes
  • Update the project release notes
  • Update the project documentation, as appropriate, with a corresponding Pull Request in the Documentation repository

@ouziel-slama ouziel-slama mentioned this pull request Dec 7, 2024
Closed
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 8, 2024
View reviewed changes
counterparty-core/counterpartycore/lib/api/api_server.py
logger.info("API Server stopped.")


def is_process_alive(pid):
"""Check For the existence of a unix pid."""
try:

Check warning

Code scanning / pylint

Unnecessary "else" after "return", remove the "else" and de-indent the code inside it. Warning

Unnecessary "else" after "return", remove the "else" and de-indent the code inside it.
@ouziel-slama ouziel-slama merged commit fa93a6e into sighash Dec 9, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamkrellenstein adamkrellenstein adamkrellenstein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ouziel-slama @adamkrellenstein @Ouziel