-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated dependencies and workflow for riscv64. #449
base: main
Are you sure you want to change the base?
Conversation
@@ -9,11 +9,7 @@ runs: | |||
run: | | |||
sudo apt-get update | |||
sudo add-apt-repository ppa:ubuntu-toolchain-r/test | |||
sudo apt-get install gcc-13 g++-13 -y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't able to find a gcc-13 with riscv.
I think the riscv compiler on ubuntu-20.04 is gcc-9.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @fire, is it necessary to downgrade this to gcc-9?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I was trying to upgrade to 24.04 which has gcc 13, but I messed up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main issue with using Ubuntu 24.04 is the GLIBC versions are different and many folks on certain distributions like Kubuntu for example are unable to run the compiled shared library because the OS has an older GLIBC version installed IIRC.
Originally I think we were compiling on Ubuntu 22 and decided to fallback to 20 because of this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue is trying to get a gcc-13 riscv cross compiler, not sure how to find one that isn't like 24.04.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, could we go the other way. Would it be possible to use gcc-9 on Ubuntu 20 for the risc-v artifacts and gcc-13 for others? We could use the arch matrix bit to toggle the GCC version perhaps?
The only limitation I think that would impose for us is that we'd be bound by whatever GCC feature set is available in gcc-9 -- and we'd at least see if I've added some constructs that don't compile on gcc-9, too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can try it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to edit my branch.
… from 24.04 to 20.04 for the Linux riscv64 (Release) job.
Working on a proof of concept of using librisc linux as a cross platform compiled platform for gdextensions on many platforms including windows, macos and linux.
https://github.com/fwsGonzo/libriscv/tree/master
Part of #448