-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce window modes with overlay and transparent overlay #355
Merged
CrazyMarvin
merged 19 commits into
Crazy-Marvin:development
from
fperera123:feature/overlay-mode
Sep 9, 2024
Merged
Introduce window modes with overlay and transparent overlay #355
CrazyMarvin
merged 19 commits into
Crazy-Marvin:development
from
fperera123:feature/overlay-mode
Sep 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #332
Special thanks to @rizvanaga for the inspiring idea behind these updates
Change Log
Added Window Mode Management
Files Affected:
src/main/main.ts
src/main/windowHandler.ts
src/main/windowMode.ts
src/main/windowState.ts
src/renderer/lib/utils.ts
src/renderer/config/app.ts
src/renderer/pages/dashboard.tsx
src/renderer/pages/login.tsx
src/renderer/pages/settings/general.tsx
Changes:
WindowModeManager
to handle multiple window modes (overlay
,overlayTransparent
,windowed
) and persist state using local storage.getWindowOptions
function that adjusts window behavior based on the mode (e.g., transparent overlays, drag areas, always-on-top properties).Improved UI/UX for Overlay and Transparent Modes
Files Affected:
src/renderer/pages/dashboard.tsx
src/renderer/globals.css
Changes:
Enhanced Responsiveness and UI Scaling
Files Affected:
tailwind.config.js
src/renderer/pages/dashboard.tsx
src/renderer/pages/settings/general.tsx
Changes:
2xs
,xs
) in the Tailwind configuration, allowing better scaling for smaller devices.Business Logic Improvements and Error Handling
Files Affected:
src/main/main.ts
src/renderer/pages/login.tsx
src/renderer/lib/utils.ts
Changes:
windowed
mode if the user is in an overlay, preventing authentication errors in transparent or overlay windows.