JsonNormalizer accepting json_encode flags
#512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boesing
force-pushed
the
feature/normalizer-json-flags
branch
2 times, most recently
from
2f321fd
to
5ccbaad
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This allows the JSON normalizer to accept some `JSON_*` constant options to be passed to `json_encode` via `flags` option. Signed-off-by: Maximilian Bösing <[email protected]>
Signed-off-by: Maximilian Bösing <[email protected]>
boesing
force-pushed
the
feature/normalizer-json-flags
branch
from
5ccbaad
to
e0eec68
Compare
Signed-off-by: Maximilian Bösing <[email protected]>
|
FYI: This adds additional time to the static analysis checks due to the |
This annotation leads to severe performance issues when running PHPStan analysis, also this annotation does not work well with PHPStan, therefore we prefer to avoid it.
Also makes the property private, we can force-access its value in tests where needed.
This class is internal and always instantiated by `JsonNormalizer` which already filters the bitmask.
|
@boesing excellent work, thank you for the contribution! I pushed some changes, I'll let you review them and comment if needed. When it's ready, let's ship it! 🚀 |
boesing
commented
Apr 2, 2024
| ); | ||
|
|
||
| // `$lowerManhattanAsJson` is a valid JSON string representing the data: | ||
| // {"longitude":"40.7128","latitude":-74.0000} |
There was a problem hiding this comment.
hm, somehow the longitude got string here. need to change this
src/Normalizer/JsonNormalizer.php
Outdated
| * ); | ||
| * | ||
| * // `$lowerManhattanAsJson` is a valid JSON string representing the data: | ||
| * // {"longitude":"40.7128","latitude":-74.0000} |
There was a problem hiding this comment.
longitude shouldnt be string here as well
|
@boesing just updated after #476 (comment) Waiting for your review before merging! |
|
LGTM! Thanks for talking over. |
TimWolla
reviewed
Apr 3, 2024
TimWolla
reviewed
Apr 3, 2024
|
Thank you for this excellent contribution @boesing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #476, this PR introduces a new
JsonNormalizer#withOptionsmethod accepting the followingJSON_*constant values as an integer bitmask:JSON_HEX_QUOTJSON_HEX_TAGJSON_HEX_AMPJSON_HEX_APOSJSON_INVALID_UTF8_IGNOREJSON_INVALID_UTF8_SUBSTITUTEJSON_NUMERIC_CHECKJSON_PRESERVE_ZERO_FRACTIONJSON_UNESCAPED_LINE_TERMINATORSJSON_UNESCAPED_SLASHESJSON_UNESCAPED_UNICODESince we should always enable
JSON_THROW_ON_ERROR, I haven't added that one to the possible constants as it is enabled by-default.Closes #476