Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added isAllowedToken, moreThanZero modifier to depositCollateralAndMi… #103

Closed
wants to merge 1 commit into from

Conversation

AAYUSH-GUPTA-coder
Copy link
Contributor

…ntDsc()

added isAllowedToken, moreThanZero modifier to depositCollateralAndMintDsc()

I think it is better practice

@EngrPips
Copy link

Hello @AAYUSH-GUPTA-coder, Thanks for this contribution. This will be attended to appropriately as soon as possible.

@AAYUSH-GUPTA-coder
Copy link
Contributor Author

Sorry, closing this.

Both functions:

depositCollateral(_tokenCollateralAddress, _amountCollateral);  
mintDsc(_amountDscToMint);  

already validating the parameters, so there's no need to check them again.

@EngrPips
Copy link

Thanks for your diligence @AAYUSH-GUPTA-coder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants