Guid generation uses New, Add Ulid support

Cysharp · Feb 7, 2022 · c8c72dd · c8c72dd
1 parent e810d72
commit c8c72dd
Show file tree

Hide file tree

Showing 5 changed files with 46 additions and 1 deletion.
diff --git a/README.md b/README.md
@@ -227,9 +227,10 @@ public static bool operator false(Foo x) => !x.value;
 public static bool operator !(Foo x) => !x.value;
 ```
 
-> When type is Guid, also implements `New***` static operator.
+> When type is Guid or [Ulid](https://github.com/Cysharp/Ulid), also implements `New()` and `New***()` static operator.
 
 ```csharp
+public static GroupId New();
 public static GroupId NewGroupId();
 ```
 

diff --git a/sandbox/ConsoleApp/ConsoleApp.csproj b/sandbox/ConsoleApp/ConsoleApp.csproj
@@ -13,6 +13,8 @@
         <PackageReference Include="Dapper" Version="2.0.78" />
         <PackageReference Include="MessagePack" Version="2.2.85" />
         <PackageReference Include="Microsoft.EntityFrameworkCore" Version="5.0.1" />
+        <PackageReference Include="Ulid" Version="1.2.6" />
+        <PackageReference Include="Ulid.MessagePack" Version="1.2.6" />
     </ItemGroup>
 
     <ItemGroup>

diff --git a/sandbox/ConsoleApp/Program.cs b/sandbox/ConsoleApp/Program.cs
@@ -18,6 +18,9 @@ public readonly partial struct NoNamespace
 [UnitOf(typeof(Guid), UnitGenerateOptions.Comparable | UnitGenerateOptions.WithoutComparisonOperator)]
 public readonly partial struct FooId { }
 
+[UnitOf(typeof(Ulid), UnitGenerateOptions.Comparable | UnitGenerateOptions.WithoutComparisonOperator | UnitGenerateOptions.MessagePackFormatter)]
+public readonly partial struct BarId { }
+
 namespace Sample
 {
 
@@ -34,6 +37,9 @@ void Foo()
             _ = FooId.NewFooId();
             Guid.NewGuid();
 
+
+
+
         }
 
     }

diff --git a/src/UnitGenerator/CodeTemplate.cs b/src/UnitGenerator/CodeTemplate.cs
@@ -124,13 +124,31 @@ public virtual string TransformText()
  if (Type == "Guid" || Type == "System.Guid") { 
             this.Write("        public static ");
             this.Write(this.ToStringHelper.ToStringWithCulture(Name));
+            this.Write(" New()\r\n        {\r\n            return new ");
+            this.Write(this.ToStringHelper.ToStringWithCulture(Name));
+            this.Write("(Guid.NewGuid());\r\n        }\r\n\r\n        public static ");
+            this.Write(this.ToStringHelper.ToStringWithCulture(Name));
             this.Write(" New");
             this.Write(this.ToStringHelper.ToStringWithCulture(Name));
             this.Write("()\r\n        {\r\n            return new ");
             this.Write(this.ToStringHelper.ToStringWithCulture(Name));
             this.Write("(Guid.NewGuid());\r\n        }\r\n\r\n");
  } 
             this.Write("\r\n");
+ if (Type == "Ulid" || Type == "System.Ulid") { 
+            this.Write("        public static ");
+            this.Write(this.ToStringHelper.ToStringWithCulture(Name));
+            this.Write(" New()\r\n        {\r\n            return new ");
+            this.Write(this.ToStringHelper.ToStringWithCulture(Name));
+            this.Write("(Ulid.NewGuid());\r\n        }\r\n\r\n        public static ");
+            this.Write(this.ToStringHelper.ToStringWithCulture(Name));
+            this.Write(" New");
+            this.Write(this.ToStringHelper.ToStringWithCulture(Name));
+            this.Write("()\r\n        {\r\n            return new ");
+            this.Write(this.ToStringHelper.ToStringWithCulture(Name));
+            this.Write("(Ulid.NewGuid());\r\n        }\r\n\r\n");
+ } 
+            this.Write("\r\n");
  if (HasFlag(UnitGenerateOptions.ParseMethod)) { 
             this.Write(" \r\n        // UnitGenerateOptions.ParseMethod\r\n\r\n        public static ");
             this.Write(this.ToStringHelper.ToStringWithCulture(Name));

diff --git a/src/UnitGenerator/CodeTemplate.tt b/src/UnitGenerator/CodeTemplate.tt
@@ -102,13 +102,31 @@ namespace <#= Namespace #>
         }
 
 <# if (Type == "Guid" || Type == "System.Guid") { #>
+        public static <#= Name #> New()
+        {
+            return new <#= Name #>(Guid.NewGuid());
+        }
+
         public static <#= Name #> New<#= Name #>()
         {
             return new <#= Name #>(Guid.NewGuid());
         }
 
 <# } #>
 
+<# if (Type == "Ulid" || Type == "System.Ulid") { #>
+        public static <#= Name #> New()
+        {
+            return new <#= Name #>(Ulid.NewGuid());
+        }
+
+        public static <#= Name #> New<#= Name #>()
+        {
+            return new <#= Name #>(Ulid.NewGuid());
+        }
+
+<# } #>
+
 <# if (HasFlag(UnitGenerateOptions.ParseMethod)) { #> 
         // UnitGenerateOptions.ParseMethod