ToString generate only value in default

Cysharp · Dec 28, 2021 · e2e050e · e2e050e
1 parent 266d105
commit e2e050e
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/README.md b/README.md
@@ -40,7 +40,7 @@ public readonly partial struct UserId : IEquatable<UserId>
     public bool Equals(UserId other) => value.Equals(other.value);
     public override bool Equals(object? obj) => // snip...
     public override int GetHashCode() => value.GetHashCode();
-    public override string ToString() => "UserId(" + value + ")";
+    public override string ToString() => value.ToString();
     public static bool operator ==(in UserId x, in UserId y) => x.value.Equals(y.value);
     public static bool operator !=(in UserId x, in UserId y) => !x.value.Equals(y.value);
 
@@ -75,7 +75,7 @@ public readonly partial struct Hp : IEquatable<Hp> , IComparable<Hp>
     public bool Equals(Hp other) => value.Equals(other.value);
     public override bool Equals(object? obj) => // snip...
     public override int GetHashCode() => value.GetHashCode();
-    public override string ToString() => "Hp(" + value + ")";
+    public override string ToString() => value.ToString();
     public static bool operator ==(in Hp x, in Hp y) => x.value.Equals(y.value);
     public static bool operator !=(in Hp x, in Hp y) => !x.value.Equals(y.value);
     private class HpTypeConverter : System.ComponentModel.TypeConverter { /* snip... */ }
@@ -228,7 +228,7 @@ public static bool operator !(Foo x) => !x.value;
 
 Second parameter `UnitGenerateOptions options` can configure which method to implement, default is `None`.
 
-Third parameter `strign toStringFormat` can configure `ToString` format. Default is null and output as $`TypeName({0})`.
+Third parameter `strign toStringFormat` can configure `ToString` format. Default is null and output as $`{0}`.
 
 ## UnitGenerateOptions
 

diff --git a/sandbox/ConsoleApp/Program.cs b/sandbox/ConsoleApp/Program.cs
@@ -8,6 +8,7 @@
 
 
 
+Console.WriteLine(new Sample.Hp(100).ToString());
 
 [UnitOf(typeof(int))]
 public readonly partial struct NoNamespace
@@ -25,6 +26,7 @@ public readonly partial struct Hp
         void Foo()
         {
             _ = this.AsPrimitive();
+            _ = this.ToString();
         }
 
     }

diff --git a/src/UnitGenerator/CodeTemplate.cs b/src/UnitGenerator/CodeTemplate.cs
@@ -105,9 +105,7 @@ public virtual string TransformText()
                     "    public override int GetHashCode()\r\n        {\r\n            return value.GetHa" +
                     "shCode();\r\n        }\r\n\r\n        public override string ToString()\r\n        {\r\n");
  if (ToStringFormat == null) { 
-            this.Write("            return \"");
-            this.Write(this.ToStringHelper.ToStringWithCulture(Name));
-            this.Write("(\" + value + \")\";\r\n");
+            this.Write("            return value.ToString();\r\n");
  } else { 
             this.Write("            return string.Format(\"");
             this.Write(this.ToStringHelper.ToStringWithCulture(ToStringFormat));

diff --git a/src/UnitGenerator/CodeTemplate.tt b/src/UnitGenerator/CodeTemplate.tt
@@ -85,7 +85,7 @@ namespace <#= Namespace #>
         public override string ToString()
         {
 <# if (ToStringFormat == null) { #>
-            return "<#= Name #>(" + value + ")";
+            return value.ToString();
 <# } else { #>
             return string.Format("<#= ToStringFormat #>", value);
 <# } #>