Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add UUIDv7 generation option #61

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

Funkest
Copy link
Contributor

@Funkest Funkest commented Nov 18, 2024

Add optional uuidV7 parameter to New() and NewXXX() methods. When set to true, the methods use Guid.CreateVersion7().
This feature is only available when targeting .NET 9.0 or later by preprocessor directive.

@neuecc
Copy link
Member

neuecc commented Nov 19, 2024

Thank you, I think it's good.
However, since it's an overload, isn't it better to just use New(bool uuidV7) rather than New(bool uuidV7 = false)?

@kase-sanwa
Copy link
Contributor

I agree completely. I wonder why I didn't write that myself.

@neuecc
Copy link
Member

neuecc commented Nov 19, 2024

ok, thanks! I'll release soon!

@neuecc neuecc merged commit 70c5af9 into Cysharp:master Nov 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants