Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add environment identification tag in the header (409424) #483

Merged
merged 7 commits into from
Nov 15, 2024

Conversation

davidjamesstone
Copy link
Contributor

@davidjamesstone davidjamesstone commented Sep 20, 2024

Adds an environment tag to the header for story #409424

See related change in forms-runner where the "Production" tag won't be shown:


Header tag development

Header tag performance test

Header tag production

Copy link

@KiranVarma02 KiranVarma02 marked this pull request as draft October 30, 2024 09:57
@KiranVarma02 KiranVarma02 marked this pull request as ready for review October 30, 2024 13:02
Copy link
Contributor

@colinrotherham colinrotherham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @KiranVarma02

Are you happy everything works without needing tests?

You can copy the Nunjucks tests from another component if you like:
https://github.com/DEFRA/forms-designer/blob/main/designer/server/src/common/components/heading/template.test.js

designer/server/src/common/nunjucks/context/index.js Outdated Show resolved Hide resolved
@colinrotherham colinrotherham changed the title Add environment identification tag in the header Add environment identification tag in the header (409424) Nov 14, 2024
@colinrotherham colinrotherham force-pushed the feature/290089-form-overview-page branch from bb1e773 to eb7babf Compare November 14, 2024 21:59
@colinrotherham colinrotherham force-pushed the feature/290089-form-overview-page branch from eb7babf to 35af703 Compare November 15, 2024 08:47
@colinrotherham colinrotherham force-pushed the feature/290089-form-overview-page branch from 35af703 to a9e1bcd Compare November 15, 2024 09:07
@colinrotherham colinrotherham merged commit bf808e8 into main Nov 15, 2024
10 checks passed
@colinrotherham colinrotherham deleted the feature/290089-form-overview-page branch November 15, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants