Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming "unforbid" to "claim". #3339

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Renaming "unforbid" to "claim". #3339

wants to merge 5 commits into from

Conversation

Penumbra69
Copy link

@Penumbra69 Penumbra69 commented May 2, 2023 •
edited
Loading

  • Added an alias "unforbid -> claim" in the init
  • related to dfhack #3183

Penumbra69 added 4 commits May 1, 2023 18:18
@Penumbra69
Renaming "unforbid" to "claim".
70ee8fb 
 - unforbid.lua -> claim.lua
 - unforbid.rst -> claim.rst
 - update documentation to use claim / claimed
 - Update "forbid.lua" to hint at "claim all"
 - added a note to the changelog.txt
 - Added an alias "unforbid -> claim" in the init
@Penumbra69
Merge branch 'develop' into rename_unforbid_claim
6ff73a3
@Penumbra69
Renaming "unforbid" to "claim".
bb4d243 
 - Skip anchors (..)
 - Anchor unforbid docs to claim.rst
@Penumbra69
Renaming "unforbid" to "claim".
ac4a8ce 
 - Skip anchors (..)
 - Anchor unforbid docs to claim.rst
@lethosor
Copy link
Member

lethosor commented May 2, 2023

Per my ramblings on Discord: I'm wondering if this is the direction we want to go, or if just aliasing claim to unforbid would better serve more users. As it stands, without changes to helpdb, one of the commands (whichever is an alias) will be excluded from certain lists and functionality, and unforbid has been around for longer.

@myk002
Copy link
Member

myk002 commented May 2, 2023

I put my thoughts on this subject here: #3342

@myk002
Copy link
Member

myk002 commented May 4, 2023

@Penumbra69 do you think you could possibly implement the first two items in #3342 ? That is, link up aliases in helpdb so they have help entries? That will take care of them appearing in the autocomplete list and showing appropriate help text when they're in the active commandline.

@Penumbra69
Copy link
Author

@Penumbra69 do you think you could possibly implement the first two items in #3342 ? That is, link up aliases in helpdb so they have help entries? That will take care of them appearing in the autocomplete list and showing appropriate help text when they're in the active commandline.

I'll take a look at this tonight, sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Penumbra69 @lethosor @myk002