thread safety checks #5120
Open
thread safety checks #5120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also removed some dead code and fixed a problem with shutdown
ab9rf
force-pushed
the
thread-safety-checks
branch
from
cd6fe14 to
2c8ade8
Compare
this avoids a deadlock risk that would otherwise arise
myk002
approved these changes
Dec 22, 2024
library/Core.cpp
Outdated
| // DF only calls the sdl input event hook from the render thread | ||
| // we use this to identify the render thread | ||
| // | ||
| // first time this is called, set df_render_thread to calling thread |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main thing this PR does is add some code to monitor for attempts to acquire a
CoreSuspenderfrom the DF render thread, which is impermissible and will lead to deadlock. It currently only uses anassertfor this (which means it's only operational in a debug build).It also removes some dead code related to threading and fixes a couple of semantic errors:
Core::Shutdownattempts to unlock the main core lock, but cannot do so because it always runs on the render thread while the main core lock is held by the simulation thread. This is replaced by an atomic flagshutdownwhichCore::Shutdownsets and whichCore::Updatechecks.CoreSuspenderto save plugin site and world data. Plugin unload during shutdown cannot acquire aCoreSuspender(because shutdown runs on the render thread), so unload now skips saving plugin site and world data during shutdown. This is harmless because site and world data cannot be saved during shutdown anyway.