Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Getter functions to CCPACSPositionings.h #1046

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Conversation

merakulix
Copy link
Contributor

Added Getter functions to CCPACSPositionings.h to make Positionings available via Python Bindings, which is currently not true for classes that store elements using the std::vector<std::unique_prt<TYPE>> and don't provide getter functions that return elements by index.

For further information see RISCSoftware/cpacs_tigl_gen#59

Description

New Functions:

CCPACSPositionings::GetPositioningCount()
CCPACSPositionings::GetPositioning(int index)

Implements Getter functions manually, as discussed in RISCSoftware/cpacs_tigl_gen#59, to fix missing functionality as described in #936.
Functions returning the type std::vector<std::unique_prt<TYPE>> will still not be available via Python Bindings.

How Has This Been Tested?

Added a test, checking missing functionality described in #936

Checklist:

Task Finished Reviewer Approved
At least one test for the new functionality was added.
  • yes
  • does not apply
  • OK
New classes have been added to the Python interface.
  • yes
  • does not apply
  • OK
The code is properly documented with doxygen docstrings
  • yes
  • does not apply
  • OK
Changes are documented at the top of ChangeLog.md
  • yes
  • does not apply
  • OK

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.48%. Comparing base (4adb704) to head (b5a9f3c).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1046   +/-   ##
=======================================
  Coverage   69.47%   69.48%           
=======================================
  Files         301      301           
  Lines       26887    26894    +7     
=======================================
+ Hits        18681    18688    +7     
  Misses       8206     8206           
Flag Coverage Δ
unittests 69.48% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/CCPACSPositionings.cpp 95.71% <100.00%> (+0.47%) ⬆️

@joergbrech joergbrech changed the title Issue936 Added Getter functions to CCPACSPositionings.h Dec 19, 2024
@merakulix
Copy link
Contributor Author

I'd like to add, I formatted some docstrings that were not part of this Issue, since we discussed improving tigls generated documentation by Doxygen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant