Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement five _mm_cmpestr #552

Merged
merged 1 commit into from
Nov 10, 2022
Merged

Implement five _mm_cmpestr #552

merged 1 commit into from
Nov 10, 2022

Conversation

Cuda-Chen
Copy link
Collaborator

Implement _mm_cmpestra, _mm_cmpestrc, _mm_cmpestro, _mm_cmpestrs, and _mm_cmpestrz.

sse2neon.h Outdated Show resolved Hide resolved
sse2neon.h Outdated Show resolved Hide resolved
@jserv
Copy link
Member

jserv commented Nov 8, 2022

Are you ready to close #308 ? If so, append Close #308 at the end of git commit message.

sse2neon.h Outdated Show resolved Hide resolved
sse2neon.h Outdated Show resolved Hide resolved
sse2neon.h Outdated Show resolved Hide resolved
@Cuda-Chen
Copy link
Collaborator Author

Are you ready to close #308 ? If so, append Close #308 at the end of git commit message.

The _mm_cmpistr series has not be implemented yet.
However, should we create another issue to track the progress of implementing _mm_cmpistr series?

@jserv
Copy link
Member

jserv commented Nov 9, 2022

should we create another issue to track the progress of implementing _mm_cmpistr series?

No, let's track on #308

@Cuda-Chen Cuda-Chen requested a review from jserv November 9, 2022 13:35
sse2neon.h Outdated
la = SSE2NEON_MIN(la, bound); \
lb = SSE2NEON_MIN(lb, bound);

#define SSE2NEON_CMPESTRX_GET_UPPER_BOUND \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you modify the function body of _mm_cmpestri and _mm_cmpestrm as well?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SSE2NEON_CMPESTRX_GET_UPPER_BOUND macro is used for getting upper-bound of byte/word. What's more, _mm_cmpestrs and _mm_cmpestrz need the upper-bound information to decide whether the input string hits upper-bound or not.

sse2neon.h Outdated Show resolved Hide resolved
Implement _mm_cmpestra, _mm_cmpestrc, _mm_cmpestro,
_mm_cmpestrs, and _mm_cmpestrz.
@Cuda-Chen Cuda-Chen requested a review from jserv November 10, 2022 14:47
@jserv jserv merged commit d6dcd6f into DLTcollab:master Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants