-
-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test OpenCL #94
base: master
Are you sure you want to change the base?
Test OpenCL #94
Conversation
bkmgit
commented
Oct 22, 2022
- Partially addresses CI tests #90
- Can squash commits.
- The precision tests cause a segmentation fault, probably due to memory requirements. Maybe a small set of test cases can be considered?
Compare Pocl code against FFTW
Try to get CI to work as failing because OpenCl library is not found.
Add a missing additional dependency
libopencl is not installed
Hello, Thank you for the effort, I will need to check on how this will work and decide on the small set of tests that can be done in CI (and to automatically decide if accuracy is good) - then it can be done as a separate script file. I think it will be better this way, than just relaunching all precision verification scripts every time. Best regards, |
Thanks for the library. Some of the precision failures may be due to the implementations of OpenCl/Vulkan not just the FFT library. Can add other possible backends, in particular llvmpipe and HIP-CPU that can run on CPU once a subset of tests is chosen. These will also be helpful for packaging the library in Linux distributions. |