This repository has been archived by the owner on Apr 29, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 548
Trust: changed way to generate the list of trust. #6352
Open
Omnione
wants to merge
10
commits into
DarkstarProject:master
Choose a base branch
from
Omnione:Trust_Main
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and QueryTrust to iterate through the list to generate a list of trust. Cleaned up some other bits and pieces.
…into Trust_Main
…into Trust_Main
man i keep forgetting to change the title, lol |
wtf, this builds fine for me, hmm |
Ok 3rd time lucky |
If this last commit dont work can somone else take a look and find out what the hell im doing wrong please |
TeoTwawki
reviewed
Jan 5, 2020
I have added the addition of a global trust.lua just incase we need it later on for something and made all the trust scripts require it. and fixed the fact i left out the changes to LoadTrustlist in map.ccp |
…re as might need it, removed requires from trust.lua
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trust: This creates vector list of trust id's and query's the id's then generates a new g_PTrustList. just like the g_PPetlist, that can iterated through using the trustID so you can call the trust using the spellid rather than the old way of adding a massive amount of magic numbers in pet_list.sql or somthing like that.
The only real logic that i changed was the order of adding trust to the list of spawned trust so they follow each other from first spawned onwards down the list.
fixed some heap errors due to the tick still running after despawn.
No combat changes or stat changes have been made, you still can't cast on trust and trust wont cast or perform weapon skills/abilities either.