-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto Multiline v2 - Add Legacy Regex Support #29573
Conversation
# Conflicts: # pkg/logs/internal/decoder/auto_multiline_detection/user_samples.go
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=45155262 --os-family=ubuntu Note: This applies to commit e9d4fa7 |
Regression DetectorRegression Detector ResultsRun ID: a04f98c-7878-480a-b4ab-acb93c16b708 Metrics dashboard Target profiles Baseline: c5bcbc1 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
---|---|---|---|---|---|---|
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +2.36 | [+1.62, +3.11] | 1 | Logs |
➖ | tcp_syslog_to_blackhole | ingress throughput | +1.54 | [+1.50, +1.59] | 1 | Logs |
➖ | pycheck_lots_of_tags | % cpu utilization | +0.56 | [-2.06, +3.18] | 1 | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.08, +0.08] | 1 | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.01, +0.01] | 1 | Logs |
➖ | otel_to_otel_logs | ingress throughput | -0.05 | [-0.85, +0.76] | 1 | Logs |
➖ | basic_py_check | % cpu utilization | -0.12 | [-2.90, +2.67] | 1 | Logs |
➖ | idle | memory utilization | -0.42 | [-0.47, -0.38] | 1 | Logs |
➖ | file_tree | memory utilization | -0.64 | [-0.73, -0.56] | 1 | Logs |
Bounds Checks
perf | experiment | bounds_check_name | replicates_passed |
---|---|---|---|
✅ | idle | memory_usage | 10/10 |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
/merge |
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
What does this PR do?
Adds support for custom regex patterns in auto multiline aggregation V2.
When the new feature is enabled, custom patterns configured by
auto_multi_line_extra_patterns
will be converted toauto_multi_line_detection_custom_samples
to maintain backwards compatibility.Going forward regex patterns should instead be configured with
auto_multi_line_detection_custom_samples
as it supports the ability to optionally customize the label. This allows the use of regex for not only signaling the start of a multi line log, but also matching patterns that should never be aggregated, or patterns that should be included in a multiline log.Motivation
Describe how to test/QA your changes
agent status -v
and the output for your source should look like this:Note
start_group user_sample
for the lines that matched.Run steps 2-3 again.
Update the agent config:
Run steps 2-3 again, except in step 3 note that the log should be
no_aggregate
instead ofuser_sample
.Possible Drawbacks / Trade-offs
Additional Notes