Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[NPM] Set CsmEnabled in agent payload from runtime_security_config.enabled" #29588

Closed
wants to merge 2 commits into from

Conversation

lebauce
Copy link
Contributor

@lebauce lebauce commented Sep 26, 2024

Reverts #29449

@lebauce lebauce requested review from a team as code owners September 26, 2024 09:35
@lebauce lebauce added the qa/done QA done before merge and regressions are covered by tests label Sep 26, 2024
@lebauce lebauce added team/agent-security backport/7.58.x Automatically create a backport PR to 7.58.x and removed component/system-probe labels Sep 26, 2024
@lebauce lebauce requested a review from hmahmood September 26, 2024 09:38
@pr-commenter
Copy link

pr-commenter bot commented Sep 26, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=45616889 --os-family=ubuntu

Note: This applies to commit 15fe283

@pr-commenter
Copy link

pr-commenter bot commented Sep 26, 2024

Regression Detector

Regression Detector Results

Run ID: b993957d-92fc-49a9-a6fa-56ee52119e0d Metrics dashboard Target profiles

Baseline: 1dc0946
Comparison: 8aa0f0b

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +2.05 [+1.31, +2.80] 1 Logs
basic_py_check % cpu utilization +0.46 [-2.36, +3.28] 1 Logs
otel_to_otel_logs ingress throughput +0.43 [-0.37, +1.24] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.11, +0.09] 1 Logs
idle memory utilization -0.16 [-0.20, -0.12] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.44 [-0.49, -0.39] 1 Logs
pycheck_lots_of_tags % cpu utilization -0.66 [-3.19, +1.87] 1 Logs
idle_all_features memory utilization -1.80 [-1.89, -1.72] 1 Logs
file_tree memory utilization -2.09 [-2.19, -1.99] 1 Logs

Bounds Checks

perf experiment bounds_check_name replicates_passed
idle memory_usage 10/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@lebauce lebauce added changelog/no-changelog and removed backport/7.58.x Automatically create a backport PR to 7.58.x labels Sep 26, 2024
@leeavital
Copy link
Contributor

Please make sure this doesn't break the backend build (I believe it will because we're removing a field that's referenced in BE code)

@hmahmood
Copy link
Contributor

Please make sure this doesn't break the backend build (I believe it will because we're removing a field that's referenced in BE code)

We are not removing the field (no changes to agent payload); just not setting it.

@hmahmood
Copy link
Contributor

hmahmood commented Oct 1, 2024

@lebauce are we merging this for 7.59? The only issue remaining for me is #29588 (comment)

@hmahmood hmahmood added this to the 7.59.0 milestone Oct 4, 2024
@lebauce lebauce closed this Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog component/system-probe qa/done QA done before merge and regressions are covered by tests team/agent-security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants