move sysprobe config fetcher into subpackage #29617
Conversation
brycekahle
added
changelog/no-changelog
team/ebpf-platform
qa/done
Go Package Import DifferencesBaseline: 13b26f1
|
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=45326973 --os-family=ubuntuNote: This applies to commit fbc2a1d |
Regression DetectorRegression Detector ResultsRun ID: 127da81b-6d8f-494c-a748-c6d25d33952a Metrics dashboard Target profiles Baseline: 13b26f1 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | basic_py_check | % cpu utilization | +2.51 | [-0.23, +5.26] | 1 | Logs |
| ➖ | file_tree | memory utilization | +0.01 | [-0.08, +0.10] | 1 | Logs |
| ➖ | otel_to_otel_logs | ingress throughput | +0.01 | [-0.80, +0.81] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.01 | [-0.09, +0.10] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.01, +0.01] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -0.27 | [-0.32, -0.21] | 1 | Logs |
| ➖ | idle_all_features | memory utilization | -0.33 | [-0.40, -0.26] | 1 | Logs |
| ➖ | idle | memory utilization | -0.41 | [-0.45, -0.37] | 1 | Logs |
| ➖ | pycheck_lots_of_tags | % cpu utilization | -0.69 | [-3.11, +1.73] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -1.24 | [-1.97, -0.52] | 1 | Logs |
Bounds Checks
| perf | experiment | bounds_check_name | replicates_passed |
|---|---|---|---|
| ✅ | idle | memory_usage | 10/10 |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
|
/merge |
|
🚂 MergeQueue: waiting for PR to be ready This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Use |
|
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
What does this PR do?
Moves the system-probe config fetcher helpers into a subpackage.
Motivation
To avoid unnecessary imports in processes that have no need to directly communicate with system-probe.
See #29530 (comment) for an example of this import explosion.
Describe how to test/QA your changes
Possible Drawbacks / Trade-offs
Additional Notes