-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump the franz-go group across 1 directory with 3 updates #30346
base: main
Are you sure you want to change the base?
Conversation
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 777de39 Optimization Goals: ✅ No significant changes detected
|
perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
---|---|---|---|---|---|---|
➖ | file_tree | memory utilization | +0.53 | [+0.41, +0.65] | 1 | Logs |
➖ | quality_gate_idle | memory utilization | +0.36 | [+0.32, +0.41] | 1 | Logs bounds checks dashboard |
➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | +0.25 | [-0.21, +0.72] | 1 | Logs |
➖ | file_to_blackhole_300ms_latency | egress throughput | +0.20 | [-0.43, +0.84] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency_http2 | egress throughput | +0.08 | [-0.75, +0.92] | 1 | Logs |
➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.07 | [-0.70, +0.84] | 1 | Logs |
➖ | file_to_blackhole_500ms_latency | egress throughput | +0.06 | [-0.70, +0.83] | 1 | Logs |
➖ | file_to_blackhole_100ms_latency | egress throughput | +0.02 | [-0.76, +0.80] | 1 | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.02, +0.02] | 1 | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | -0.01 | [-0.12, +0.10] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency_http1 | egress throughput | -0.05 | [-0.86, +0.76] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency | egress throughput | -0.06 | [-0.90, +0.78] | 1 | Logs |
➖ | quality_gate_logs | % cpu utilization | -0.23 | [-3.12, +2.67] | 1 | Logs |
➖ | otel_to_otel_logs | ingress throughput | -0.39 | [-1.08, +0.29] | 1 | Logs |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.58 | [-1.30, +0.15] | 1 | Logs |
➖ | tcp_syslog_to_blackhole | ingress throughput | -0.72 | [-0.78, -0.66] | 1 | Logs |
➖ | quality_gate_idle_all_features | memory utilization | -1.53 | [-1.64, -1.42] | 1 | Logs bounds checks dashboard |
Bounds Checks: ❌ Failed
perf | experiment | bounds_check_name | replicates_passed | links |
---|---|---|---|---|
❌ | file_to_blackhole_500ms_latency | lost_bytes | 9/10 | |
✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http1 | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http1 | memory_usage | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http2 | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http2 | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_300ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_logs | lost_bytes | 10/10 | |
✅ | quality_gate_logs | memory_usage | 10/10 |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
d7f152a
to
caeae3e
Compare
caeae3e
to
81407fc
Compare
b5a6b23
to
74c4ff6
Compare
93f1418
to
5da2548
Compare
5da2548
to
d90d0a4
Compare
5a8c13f
to
247f37f
Compare
247f37f
to
daee796
Compare
Bumps the franz-go group with 2 updates in the / directory: [github.com/twmb/franz-go](https://github.com/twmb/franz-go) and [github.com/twmb/franz-go/pkg/kadm](https://github.com/twmb/franz-go). Updates `github.com/twmb/franz-go` from 1.17.0 to 1.18.0 - [Changelog](https://github.com/twmb/franz-go/blob/master/CHANGELOG.md) - [Commits](twmb/franz-go@v1.17.0...v1.18.0) Updates `github.com/twmb/franz-go/pkg/kadm` from 1.12.0 to 1.14.0 - [Changelog](https://github.com/twmb/franz-go/blob/master/CHANGELOG.md) - [Commits](twmb/franz-go@v1.12.0...v1.14.0) Updates `github.com/twmb/franz-go/pkg/kmsg` from 1.8.0 to 1.9.0 - [Changelog](https://github.com/twmb/franz-go/blob/master/CHANGELOG.md) - [Commits](twmb/franz-go@v1.8.0...v1.9.0) --- updated-dependencies: - dependency-name: github.com/twmb/franz-go dependency-type: direct:production update-type: version-update:semver-minor dependency-group: franz-go - dependency-name: github.com/twmb/franz-go/pkg/kadm dependency-type: direct:production update-type: version-update:semver-minor dependency-group: franz-go - dependency-name: github.com/twmb/franz-go/pkg/kmsg dependency-type: direct:production update-type: version-update:semver-minor dependency-group: franz-go ... Signed-off-by: dependabot[bot] <[email protected]>
daee796
to
cdba78f
Compare
Bumps the franz-go group with 2 updates in the / directory: github.com/twmb/franz-go and github.com/twmb/franz-go/pkg/kadm.
Updates
github.com/twmb/franz-go
from 1.17.0 to 1.18.0Changelog
Sourced from github.com/twmb/franz-go's changelog.
... (truncated)
Commits
0a9996b
Merge pull request #841 from twmb/1.18-changelog835c682
CHANGELOG: note incoming released771ddf
Merge pull request #838 from twmb/81004356d7
Merge pull request #835 from twmb/8193d71b14
Merge pull request #834 from twmb/805019799a
Merge pull request #829 from andrewstucki/sr-client-opts3a0f09a
Merge pull request #814 from noamcohen97/new-offset-helper6028e72
Merge pull request #794 from twmb/790581d7ef
Merge pull request #789 from sbuliarca/errgroupsession-export-errfd084a5
Merge pull request #760 from twmb/753Updates
github.com/twmb/franz-go/pkg/kadm
from 1.12.0 to 1.14.0Changelog
Sourced from github.com/twmb/franz-go/pkg/kadm's changelog.
... (truncated)
Commits
f132eaa
Merge pull request #504 from twmb/bump_kmsgfa4e091
franz-go: bump kmsg to v1.6.17182514
Merge pull request #503 from twmb/kmsg_noretract23c38ff
plugin/klogrus: use fmt.Sprint7ea9b09
pkg/kmsg: avoid retract v2 directive063ab3e
Merge pull request #502 from twmb/v1.14-changelogcd58477
CHANGELOG: note incoming v1.14118e822
Merge pull request #470 from JGShaw/master6fb7260
Merge pull request #498 from twmb/ftbc4b0e4
Merge pull request #496 from twmb/kadm_listUpdates
github.com/twmb/franz-go/pkg/kmsg
from 1.8.0 to 1.9.0Changelog
Sourced from github.com/twmb/franz-go/pkg/kmsg's changelog.
Commits
24d0cfe
Merge pull request #231 from twmb/v1.9b0bc0b6
CHANGELOG: note incoming v1.9, incoming kadma4a2aaf
Merge pull request #230 from twmb/kadmd3ee144
kadm: add LeaveGroup api2ee43e3
kadm: update CalculateGroupLag documentation00209b4
kgo: add addr to sasl logsa7f5d0d
Merge pull request #229 from twmb/instance_idf8038de
kgo: consistently use \d.\d rather than \d.\d.0 for kafka versionsb18341d
kgo: work around KIP-814 limitations6cac810
kversions: bump Stable from 3.0 to 3.3You can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major version
will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor version
will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>
will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>
will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>
will remove the ignore condition of the specified dependency and ignore conditions