Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the franz-go group across 1 directory with 3 updates #30346

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 21, 2024

Bumps the franz-go group with 2 updates in the / directory: github.com/twmb/franz-go and github.com/twmb/franz-go/pkg/kadm.

Updates github.com/twmb/franz-go from 1.17.0 to 1.18.0

Changelog

Sourced from github.com/twmb/franz-go's changelog.

v1.18.0

This release adds support for Kafka 3.7, adds a few community requested APIs, some internal improvements, and fixes two bugs. One of the bugfixes is for a deadlock; it is recommended to bump to this release to ensure you do not run into the deadlock. The features in this release are relatively small.

This adds protocol support for KIP-890 and KIP-994, and adds further protocol support for [KIP-848][KIP-848]. If you are using transactions, you may see a new kerr.TransactionAbortable error, which signals that your ongoing transaction should be aborted and will not be successful if you try to commit it.

Lastly, there have been a few improvements to pkg/sr that are not mentioned in these changelog notes.

Bug fixes

  • If you canceled the context used while producing while your client was at the maximum buffered records or bytes, it was possible to experience deadlocks. This has been fixed. See #832 for more details.

  • Previously, if using GetConsumeTopics while regex consuming, the function would return all topics ever discovered. It now returns only the topics that are being consumed.

Improvements

  • The client now internaly ignores OutOfOrderSequenceNumber errors that are encountered when consuming if possible. If a producer produces very infrequently, it is possible the broker forgets the producer by the next time the producer produces. In this case, the producer receives an OutOfOrderSequenceNumber error. The client now internally resets properly so that you do not see the error.

Features

  • AllowRebalance and CloseAllowingRebalance have been added to GroupTransactSession.
  • The FetchTopic type now has includes the topic's TopicID.
  • The ErrGroupSession internal error field is now public, allowing you to test how you handle the internal error.
  • You may now receive a kerr.TransactionAbortable error from many functions while using transactions.

Relevant commits

  • 0fd1959d kgo: support Kafka 3.8's kip-890 modifications
  • 68163c55 bugfix kgo: do not add all topics to internal tps map when regex consuming
  • 3548d1f7 improvement kgo: ignore OOOSN where possible

... (truncated)

Commits

Updates github.com/twmb/franz-go/pkg/kadm from 1.12.0 to 1.14.0

Changelog

Sourced from github.com/twmb/franz-go/pkg/kadm's changelog.

v1.14.0

This release contains a few new APIs, one behavior change, and one minor bugfix.

Bug fixes

Previously, HookBrokerRead and HookBrokerE2E could not be used at the same time. This has been fixed.

Behavior changes

PauseFetch{Topics,Partitions} now causes the client to drop all buffered fetches and kill all in-flight fetch requests. Importantly, this also means that once you pause, it is no longer possible for what you paused to be returned while polling. Previously, the client made no attempt to clear internal buffers / in flight requests, meaning you could receive paused data for a while.

Seed brokers now show up in logs as seed_### rather than seed ### (an underscore has been added).

Features

  • kgo.Offset now has an EpochOffset getter function that allows access to the actual epoch and offset that are inside the opaque Offset type.
  • AddConsumePartitions allows adding individual partitions to consume, and the new counterpart RemoveConsumePartitions allows removing individual partitions from being consumed. Removing is different from purging, please see the docs.
  • KeepRetryableFetchErrors bubbles up retryable errors to the end user that are encountered while fetching. By default, these errors are stripped.
  • kversion now supports Kafka 3.5
  • kversion now supports version guessing against KRaft by default
  • kgo.DialTLS now exists to even more easily opt into TLS.
  • kgo.Client.Opts now exists to return the original options that were used to configure the client, making initializing new clients easier.
  • kgo.NodeName returns a string form of a broker node name. Internally, seed brokers use math.MinInt32 for node IDs, which shows up as massively negative numbers in logs sometimes. NodeName can help convert that to seed_<#>.

Relevant commits

  • c3b083b improvement kgo: do not returned paused topics/partitions after pausing
  • e224e90 bugfix kgo: allow HookBrokerRead and HookBrokerE2E to both be called
  • 875761a feature kgo Offset: add EpochOffset getter field
  • c5d0fc5 kgo: add a debug log for stripping retryable errors from fetches
  • b45d663 kgo: add more context to opportunistic metadata loads while fetching
  • 9dae366 kgo: allow retries on dial timeouts
  • 00e4e76 kgo: tolerate buggy v1 group member metadata

... (truncated)

Commits

Updates github.com/twmb/franz-go/pkg/kmsg from 1.8.0 to 1.9.0

Changelog

Sourced from github.com/twmb/franz-go/pkg/kmsg's changelog.

v1.9.0

This release contains one important bugfix (sequence number int32 overflow) for long-lived producers, one minor bugfix that allows this client to work on 32 bit systems, and a few other small improvements.

This project now has integration tests ran on every PR (and it is now forbidden to push directly to master). These integration tests run against Kraft (Kafka + Raft), which itself seems to not be 100% polished. A good amount of investigation went into hardening the client internals to not fail when Kraft is going sideways.

This release also improves behavior when a consumer group leader using an instance ID restarts and changes the topics it wants to consume from. See the KIP-814 commit for more details.

It is now easier to setup a TLS dialer with a custom dial timeout, it is easier to detect if requests are failing due to missing SASL, and it is now possible to print attributes with RecordFormatter.

Lastly, the corresponding kadm v1.3.0 release adds new LeaveGroup admin APIs.

franz-go

kadm

  • d3ee144 kadm: add LeaveGroup api
  • 7b8d404 kadm: ListOffsetsAfterMill(future) should return end offsets
Commits
  • 24d0cfe Merge pull request #231 from twmb/v1.9
  • b0bc0b6 CHANGELOG: note incoming v1.9, incoming kadm
  • a4a2aaf Merge pull request #230 from twmb/kadm
  • d3ee144 kadm: add LeaveGroup api
  • 2ee43e3 kadm: update CalculateGroupLag documentation
  • 00209b4 kgo: add addr to sasl logs
  • a7f5d0d Merge pull request #229 from twmb/instance_id
  • f8038de kgo: consistently use \d.\d rather than \d.\d.0 for kafka versions
  • b18341d kgo: work around KIP-814 limitations
  • 6cac810 kversions: bump Stable from 3.0 to 3.3
  • Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added changelog/no-changelog dependencies PRs that bump a dependency dependencies-go PRs that bump a go dependency team/triage labels Oct 21, 2024
Copy link

cit-pr-commenter bot commented Oct 21, 2024

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 60f96d8f-3f42-4ba2-b376-c9d58788e028

Baseline: 777de39
Comparison: cdba78f
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
file_tree memory utilization +0.53 [+0.41, +0.65] 1 Logs
quality_gate_idle memory utilization +0.36 [+0.32, +0.41] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.25 [-0.21, +0.72] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.20 [-0.43, +0.84] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.08 [-0.75, +0.92] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.07 [-0.70, +0.84] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.06 [-0.70, +0.83] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.02 [-0.76, +0.80] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.02, +0.02] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.12, +0.10] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput -0.05 [-0.86, +0.76] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.06 [-0.90, +0.78] 1 Logs
quality_gate_logs % cpu utilization -0.23 [-3.12, +2.67] 1 Logs
otel_to_otel_logs ingress throughput -0.39 [-1.08, +0.29] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -0.58 [-1.30, +0.15] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.72 [-0.78, -0.66] 1 Logs
quality_gate_idle_all_features memory utilization -1.53 [-1.64, -1.42] 1 Logs bounds checks dashboard

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_500ms_latency lost_bytes 9/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@dependabot dependabot bot force-pushed the dependabot/go_modules/franz-go-59054367dc branch 3 times, most recently from d7f152a to caeae3e Compare October 28, 2024 20:20
@dependabot dependabot bot force-pushed the dependabot/go_modules/franz-go-59054367dc branch from caeae3e to 81407fc Compare November 4, 2024 20:12
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Nov 4, 2024
@dependabot dependabot bot force-pushed the dependabot/go_modules/franz-go-59054367dc branch 2 times, most recently from b5a6b23 to 74c4ff6 Compare November 11, 2024 20:45
@L3n41c L3n41c added team/usm The USM team and removed team/triage labels Nov 12, 2024
@dependabot dependabot bot force-pushed the dependabot/go_modules/franz-go-59054367dc branch 2 times, most recently from 93f1418 to 5da2548 Compare November 21, 2024 17:29
@dependabot dependabot bot force-pushed the dependabot/go_modules/franz-go-59054367dc branch from 5da2548 to d90d0a4 Compare November 25, 2024 21:06
@dependabot dependabot bot force-pushed the dependabot/go_modules/franz-go-59054367dc branch 2 times, most recently from 5a8c13f to 247f37f Compare December 9, 2024 20:15
@dependabot dependabot bot force-pushed the dependabot/go_modules/franz-go-59054367dc branch from 247f37f to daee796 Compare December 11, 2024 16:38
Bumps the franz-go group with 2 updates in the / directory: [github.com/twmb/franz-go](https://github.com/twmb/franz-go) and [github.com/twmb/franz-go/pkg/kadm](https://github.com/twmb/franz-go).


Updates `github.com/twmb/franz-go` from 1.17.0 to 1.18.0
- [Changelog](https://github.com/twmb/franz-go/blob/master/CHANGELOG.md)
- [Commits](twmb/franz-go@v1.17.0...v1.18.0)

Updates `github.com/twmb/franz-go/pkg/kadm` from 1.12.0 to 1.14.0
- [Changelog](https://github.com/twmb/franz-go/blob/master/CHANGELOG.md)
- [Commits](twmb/franz-go@v1.12.0...v1.14.0)

Updates `github.com/twmb/franz-go/pkg/kmsg` from 1.8.0 to 1.9.0
- [Changelog](https://github.com/twmb/franz-go/blob/master/CHANGELOG.md)
- [Commits](twmb/franz-go@v1.8.0...v1.9.0)

---
updated-dependencies:
- dependency-name: github.com/twmb/franz-go
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: franz-go
- dependency-name: github.com/twmb/franz-go/pkg/kadm
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: franz-go
- dependency-name: github.com/twmb/franz-go/pkg/kmsg
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: franz-go
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/go_modules/franz-go-59054367dc branch from daee796 to cdba78f Compare December 13, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog dependencies PRs that bump a dependency dependencies-go PRs that bump a go dependency short review PR is simple enough to be reviewed quickly team/usm The USM team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant