Refactor configuration to be able to pass a different SSH key per cloud provider

[KevinFairise2]

What does this PR do?

Refactor configuration to allow using a different SSH key per cloud provider.

Motivation

Describe how to test/QA your changes

Possible Drawbacks / Trade-offs

Additional Notes

[agent-platform-auto-pr]

[Fast Unit Tests Report]

On pipeline 50684793 (CI Visibility). The following jobs did not run any unit tests:

Jobs:

• tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

[agent-platform-auto-pr]

Gitlab CI Configuration Changes

⚠️ Diff too large to display on Github.

Changes Summary

Removed	Modified	Added	Renamed
0	95	0	0

ℹ️ Diff available in the job log.

[agent-platform-auto-pr]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=50684793 --os-family=ubuntu

Note: This applies to commit b50023c

[cit-pr-commenter]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 4596c8c9-08f1-4d0b-97f1-afdd3fba6637

Baseline: a7ba911
Comparison: b50023c
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+2.13	[+1.40, +2.85]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+1.42	[+1.30, +1.55]	1	Logs bounds checks dashboard
➖	quality_gate_logs	% cpu utilization	+1.02	[-1.95, +3.99]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.17	[-0.61, +0.94]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	+0.09	[-0.37, +0.56]	1	Logs
➖	quality_gate_idle	memory utilization	+0.09	[+0.05, +0.14]	1	Logs bounds checks dashboard
➖	file_to_blackhole_100ms_latency	egress throughput	+0.08	[-0.66, +0.81]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	+0.07	[-0.56, +0.70]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	+0.04	[-0.77, +0.84]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.01	[-0.82, +0.84]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.01, +0.01]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.02	[-0.11, +0.08]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	-0.03	[-0.83, +0.77]	1	Logs
➖	file_tree	memory utilization	-0.12	[-0.24, -0.00]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-0.54	[-0.61, -0.47]	1	Logs
➖	otel_to_otel_logs	ingress throughput	-0.79	[-1.49, -0.08]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.82	[-1.59, -0.04]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10
✅	quality_gate_logs	memory_usage	10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

[KevinFairise2]

/merge

[dd-devflow]

Devflow running: /merge

View all feedbacks in Devflow UI.

---

2024-12-02 13:54:37 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

---

2024-12-02 13:56:41 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in main is 23m.

---

2024-12-02 14:03:05 UTC ⚠️ MergeQueue: This merge request build was cancelled

This merge request build was cancelled

[pducolin]

Wonder if we can recommend running inv setup from test-infra if keys are not found in the config, to update it

[KevinFairise2]

/merge -c

[KevinFairise2]

Wonder if we can recommend running inv setup from test-infra if keys are not found in the config, to update it

Indeed, I'll do a PR on test-infra to update this. I think we just miss the local key configuration, I think the others are already created when running inv setup
I will also check the behavior when no keys are configured and print a message, indicating to run inv setup if it fails

[agent-platform-auto-pr]

Package size comparison

Comparison with ancestor a7ba9110c9023ca31f2c5e913a7ff98ab31a9a5b

Diff per package

package	diff	status	size	ancestor	threshold
datadog-agent-amd64-deb	-1.40MB	✅	1270.67MB	1272.08MB	140.00MB
datadog-iot-agent-amd64-deb	0.00MB	✅	113.20MB	113.20MB	10.00MB
datadog-dogstatsd-amd64-deb	0.00MB	✅	78.32MB	78.32MB	10.00MB
datadog-heroku-agent-amd64-deb	-1.40MB	✅	526.45MB	527.85MB	70.00MB
datadog-agent-x86_64-rpm	-1.41MB	✅	1279.91MB	1281.31MB	140.00MB
datadog-agent-x86_64-suse	-1.41MB	✅	1279.91MB	1281.31MB	140.00MB
datadog-iot-agent-x86_64-rpm	0.00MB	✅	113.26MB	113.26MB	10.00MB
datadog-iot-agent-x86_64-suse	0.00MB	✅	113.26MB	113.26MB	10.00MB
datadog-dogstatsd-x86_64-rpm	0.00MB	✅	78.40MB	78.40MB	10.00MB
datadog-dogstatsd-x86_64-suse	0.00MB	✅	78.40MB	78.40MB	10.00MB
datadog-agent-arm64-deb	0.00MB	✅	1004.85MB	1004.85MB	140.00MB
datadog-iot-agent-arm64-deb	0.00MB	✅	108.67MB	108.67MB	10.00MB
datadog-dogstatsd-arm64-deb	0.00MB	✅	55.59MB	55.59MB	10.00MB
datadog-agent-aarch64-rpm	0.00MB	⚠️	1014.06MB	1014.06MB	140.00MB
datadog-iot-agent-aarch64-rpm	0.00MB	✅	108.74MB	108.74MB	10.00MB

Decision

⚠️ Warning

[KevinFairise2]

/merge

[dd-devflow]

Devflow running: /merge

View all feedbacks in Devflow UI.

---

2024-12-10 13:58:12 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 24m.