-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tagger tags to pod manifests #31565
Add tagger tags to pod manifests #31565
Conversation
5315a8a
to
6efe568
Compare
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv aws.create-vm --pipeline-id=50562623 --os-family=ubuntu Note: This applies to commit 8011703 |
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 623bea0 Optimization Goals: ✅ No significant changes detected
|
perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
---|---|---|---|---|---|---|
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +2.20 | [+1.48, +2.93] | 1 | Logs |
➖ | otel_to_otel_logs | ingress throughput | +2.06 | [+1.35, +2.77] | 1 | Logs |
➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | +0.28 | [-0.19, +0.74] | 1 | Logs |
➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.25 | [-0.55, +1.04] | 1 | Logs |
➖ | quality_gate_idle | memory utilization | +0.23 | [+0.19, +0.27] | 1 | Logs bounds checks dashboard |
➖ | quality_gate_idle_all_features | memory utilization | +0.20 | [+0.07, +0.32] | 1 | Logs bounds checks dashboard |
➖ | file_tree | memory utilization | +0.16 | [+0.04, +0.28] | 1 | Logs |
➖ | file_to_blackhole_300ms_latency | egress throughput | +0.02 | [-0.61, +0.66] | 1 | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | +0.02 | [-0.06, +0.10] | 1 | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.01, +0.01] | 1 | Logs |
➖ | file_to_blackhole_100ms_latency | egress throughput | -0.02 | [-0.75, +0.72] | 1 | Logs |
➖ | file_to_blackhole_500ms_latency | egress throughput | -0.05 | [-0.81, +0.72] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency | egress throughput | -0.05 | [-0.82, +0.73] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency_http2 | egress throughput | -0.12 | [-0.91, +0.67] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency_http1 | egress throughput | -0.15 | [-0.98, +0.68] | 1 | Logs |
➖ | tcp_syslog_to_blackhole | ingress throughput | -0.48 | [-0.55, -0.41] | 1 | Logs |
➖ | quality_gate_logs | % cpu utilization | -1.51 | [-4.42, +1.40] | 1 | Logs |
Bounds Checks: ❌ Failed
perf | experiment | bounds_check_name | replicates_passed | links |
---|---|---|---|---|
❌ | file_to_blackhole_0ms_latency_http2 | lost_bytes | 9/10 | |
✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http1 | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http1 | memory_usage | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http2 | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_300ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_logs | lost_bytes | 10/10 | |
✅ | quality_gate_logs | memory_usage | 10/10 |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
d25cfb7
to
10beced
Compare
1fa6f5b
to
d938099
Compare
4cad0be
to
ce741b2
Compare
/merge |
Devflow running:
|
pkg/collector/corechecks/cluster/orchestrator/processors/k8s/pod.go
Outdated
Show resolved
Hide resolved
/merge |
Devflow running:
|
/merge |
Devflow running:
|
/merge |
Devflow running:
|
/merge |
Devflow running:
|
What does this PR do?
The manifest payloads have already had a tags field added to the payloads - but we need to add all the tags to the individual manifest the agent would normally send to only the orch track to the orchmanif track too.
I tested that it works on my local minikube cluster.
Motivation
Describe how to test/QA your changes
Possible Drawbacks / Trade-offs
Additional Notes